Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Map dark mode #553

Draft
wants to merge 4 commits into
base: dev
Choose a base branch
from
Draft

Map dark mode #553

wants to merge 4 commits into from

Conversation

PaulioRandall
Copy link
Contributor

What does this change?

Adds dark mode to Map component including new properties to set light and dark map styles.

How?

A style value must no longer be provided to the options prop.

Adds props:

  • lightStyle: light map style to use or null to disable light mode.
  • darkStyle: dark map style to use or null to disable dark mode.

How is it tested?

Storybook.

How is it documented?

Storybook.

Are light and dark themes considered?

Yes.

Is it complete?

  • Have you included changeset file?
  • If this adds a new component, is it exported via index.js?

@PaulioRandall PaulioRandall marked this pull request as ready for review September 2, 2024 08:56
@jamesscottbrown jamesscottbrown marked this pull request as draft December 20, 2024 10:42
@jamesscottbrown
Copy link
Collaborator

We will extract out part of this as a separate PR.

@jamesscottbrown jamesscottbrown changed the base branch from next-map to dev January 3, 2025 12:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@PaulioRandall @jamesscottbrown