WIP: start refactor of modals and tooltips #346
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The idea is that each "help provider" (tooltip, popover, modal) can render both its "trigger" and it's content. There is a standard `Trigger` component: it receives a context containing functions to call when it is interacted with.
…-viz-tools into modal-tooltip-refactor
…-viz-tools into modal-tooltip-refactor
…actionProps props for passing into Button
…ctions of modal for easier parsing
…s as per best practice
…syntax for conciseness
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The idea is that each "help provider" (tooltip, popover, modal) can render both its "trigger" and it's content.
There is a standard
Triggercomponent: it receives a context containing functions to call when it is interacted with.This is a very incomplete WIP that I've added as a draft PR so I don't forget the idea.