remove obsolete MapApp component

Greater-London-Authority · Dec 20, 2024 · f24b4a5 · f24b4a5
1 parent a3726bf
commit f24b4a5
Show file tree

Hide file tree

Showing 10 changed files with 27 additions and 91 deletions.
diff --git a/.changeset/delete-mapapp.md b/.changeset/delete-mapapp.md
@@ -0,0 +1,5 @@
+---
+'@ldn-viz/maps': major
+---
+
+REMOVED: removed `MappApp` component, which was replaced by `AppShell`
diff --git a/packages/maps/src/lib/index.js b/packages/maps/src/lib/index.js
@@ -1,7 +1,6 @@
 // Map
 export * from './map/Map.svelte';
 export { default as Map } from './map/Map.svelte';
-export { default as MapApp } from './map/MapApp.svelte';
 
 // Controls
 export { default as MapControlFullscreen } from './mapControlFullscreen/MapControlFullscreen.svelte';

diff --git a/packages/maps/src/lib/map/MapApp.svelte b/packages/maps/src/lib/map/MapApp.svelte
diff --git a/packages/maps/src/lib/mapControlBorough/MapControlBorough.stories.svelte b/packages/maps/src/lib/mapControlBorough/MapControlBorough.stories.svelte
@@ -14,7 +14,6 @@
 	import { Template, Story } from '@storybook/addon-svelte-csf';
 
 	import * as os_light_vts from '../themes/os_light_vts.json';
-	import MapApp from '../map/MapApp.svelte';
 	import Map, { appendOSKeyToUrl } from '../map/Map.svelte';
 
 	import MapControlGroup from '../mapControlGroup/MapControlGroup.svelte';
@@ -32,7 +31,7 @@
 </Template>
 
 <Story name="Zooming to borough">
-	<MapApp>
+	<div class="w-[100dvw] h-[100dvh]">
 		<Map
 			options={{
 				style: os_light_vts,
@@ -46,5 +45,5 @@
 
 			<BoroughsContextLayer />
 		</Map>
-	</MapApp>
+	</div>
 </Story>
diff --git a/packages/maps/src/lib/mapControlFullscreen/MapControlFullscreen.stories.svelte b/packages/maps/src/lib/mapControlFullscreen/MapControlFullscreen.stories.svelte
@@ -2,7 +2,6 @@
 	import { Meta, Story, Template } from '@storybook/addon-svelte-csf';
 
 	import Map, { appendOSKeyToUrl } from '../map/Map.svelte';
-	import MapApp from '../map/MapApp.svelte';
 	import * as os_light_vts from '../themes/os_light_vts.json';
 
 	import MapControlFullscreen from '../mapControlFullscreen/MapControlFullscreen.svelte';
@@ -24,7 +23,7 @@
 </Template>
 
 <Story name="Fullscreen Button">
-	<MapApp>
+	<div class="w-[100dvw] h-[100dvh]">
 		<div class="text-color-text-primary space-y-4 m-2">
 			<p>
 				The fullscreen button is usually positioned in the bottom left corner above the refresh page
@@ -49,5 +48,5 @@
 				<MapControlFullscreen />
 			</MapControlGroup>
 		</Map>
-	</MapApp>
+	</div>
 </Story>
diff --git a/packages/maps/src/lib/mapControlGroup/MapControlGroup.stories.svelte b/packages/maps/src/lib/mapControlGroup/MapControlGroup.stories.svelte
@@ -2,7 +2,6 @@
 	import { Meta, Story, Template } from '@storybook/addon-svelte-csf';
 
 	import Map, { appendOSKeyToUrl } from '../map/Map.svelte';
-	import MapApp from '../map/MapApp.svelte';
 	import * as os_light_vts from '../themes/os_light_vts.json';
 
 	import MapControlFullscreen from '../mapControlFullscreen/MapControlFullscreen.svelte';
@@ -29,7 +28,7 @@
 </Template>
 
 <Story name="Positioning labels">
-	<MapApp>
+	<div class="w-[100dvw] h-[100dvh]">
 		<Map
 			options={{
 				style: os_light_vts,
@@ -58,11 +57,11 @@
 				</p>
 			</div>
 		</Map>
-	</MapApp>
+	</div>
 </Story>
 
 <Story name="Positioning controls">
-	<MapApp>
+	<div class="w-[100dvw] h-[100dvh]">
 		<Map
 			options={{
 				style: os_light_vts,
@@ -90,11 +89,11 @@
 				</p>
 			</div>
 		</Map>
-	</MapApp>
+	</div>
 </Story>
 
 <Story name="Standard Layout">
-	<MapApp>
+	<div class="w-[100dvw] h-[100dvh]">
 		<Map
 			options={{
 				style: os_light_vts,
@@ -135,5 +134,5 @@
 				<MapControlPan />
 			</MapControlGroup>
 		</Map>
-	</MapApp>
+	</div>
 </Story>
diff --git a/packages/maps/src/lib/mapControlLocationSearch/MapControlLocationSearch.stories.svelte b/packages/maps/src/lib/mapControlLocationSearch/MapControlLocationSearch.stories.svelte
@@ -14,7 +14,6 @@
 	import { Template, Story } from '@storybook/addon-svelte-csf';
 
 	import * as os_light_vts from '../themes/os_light_vts.json';
-	import MapApp from '../map/MapApp.svelte';
 	import Map, { appendOSKeyToUrl } from '../map/Map.svelte';
 
 	import MapControlGroup from '../mapControlGroup/MapControlGroup.svelte';
@@ -37,7 +36,7 @@
 </Template>
 
 <Story name="Location Search">
-	<MapApp>
+	<div class="w-[100dvw] h-[100dvh]">
 		<Map
 			options={{
 				style: os_light_vts,
@@ -48,11 +47,11 @@
 				<MapControlLocationSearch {adapter} {onSearchError} />
 			</MapControlGroup>
 		</Map>
-	</MapApp>
+	</div>
 </Story>
 
 <Story name="Location Search - custom placeholder">
-	<MapApp>
+	<div class="w-[100dvw] h-[100dvh]">
 		<Map
 			options={{
 				style: os_light_vts,
@@ -67,11 +66,11 @@
 				/>
 			</MapControlGroup>
 		</Map>
-	</MapApp>
+	</div>
 </Story>
 
 <Story name="Hidden Geolocator">
-	<MapApp>
+	<div class="w-[100dvw] h-[100dvh]">
 		<Map
 			options={{
 				style: os_light_vts,
@@ -82,5 +81,5 @@
 				<MapControlLocationSearch {adapter} {onSearchError} hideGeolocator />
 			</MapControlGroup>
 		</Map>
-	</MapApp>
+	</div>
 </Story>
diff --git a/packages/maps/src/lib/mapControlPan/MapControlPan.stories.svelte b/packages/maps/src/lib/mapControlPan/MapControlPan.stories.svelte
@@ -2,7 +2,6 @@
 	import { Meta, Story, Template } from '@storybook/addon-svelte-csf';
 
 	import Map, { appendOSKeyToUrl } from '../map/Map.svelte';
-	import MapApp from '../map/MapApp.svelte';
 	import * as os_light_vts from '../themes/os_light_vts.json';
 
 	import MapControlGroup from '../mapControlGroup/MapControlGroup.svelte';
@@ -24,7 +23,7 @@
 </Template>
 
 <Story name="Pan Buttons">
-	<MapApp>
+	<div class="w-[100dvw] h-[100dvh]">
 		<div class="text-color-text-primary space-y-4 m-2">
 			<p>
 				The zoom buttons are usually positioned in the top left corner under the location search.
@@ -54,5 +53,5 @@
 				<MapControlPan />
 			</MapControlGroup>
 		</Map>
-	</MapApp>
+	</div>
 </Story>
diff --git a/packages/maps/src/lib/mapControlRefresh/MapControlRefresh.stories.svelte b/packages/maps/src/lib/mapControlRefresh/MapControlRefresh.stories.svelte
@@ -2,7 +2,6 @@
 	import { Meta, Story, Template } from '@storybook/addon-svelte-csf';
 
 	import Map, { appendOSKeyToUrl } from '../map/Map.svelte';
-	import MapApp from '../map/MapApp.svelte';
 	import * as os_light_vts from '../themes/os_light_vts.json';
 
 	import MapControlGroup from '../mapControlGroup/MapControlGroup.svelte';
@@ -24,7 +23,7 @@
 </Template>
 
 <Story name="Refresh Button">
-	<MapApp>
+	<div class="w-[100dvw] h-[100dvh]">
 		<div class="text-color-text-primary space-y-4 m-2">
 			<p>
 				The refresh page button is usually positioned in the bottom left corner under the fullscreen
@@ -42,5 +41,5 @@
 				<MapControlRefresh />
 			</MapControlGroup>
 		</Map>
-	</MapApp>
+	</div>
 </Story>
diff --git a/packages/maps/src/lib/mapControlZoom/MapControlZoom.stories.svelte b/packages/maps/src/lib/mapControlZoom/MapControlZoom.stories.svelte
@@ -2,7 +2,6 @@
 	import { Meta, Story, Template } from '@storybook/addon-svelte-csf';
 
 	import Map, { appendOSKeyToUrl } from '../map/Map.svelte';
-	import MapApp from '../map/MapApp.svelte';
 	import * as os_light_vts from '../themes/os_light_vts.json';
 
 	import MapControlGroup from '../mapControlGroup/MapControlGroup.svelte';
@@ -24,7 +23,7 @@
 </Template>
 
 <Story name="Zoom Buttons">
-	<MapApp>
+	<div class="w-[100dvw] h-[100dvh]">
 		<div class="text-color-text-primary space-y-4 m-2">
 			<p>
 				The zoom buttons are usually positioned in the top left corner under the location search.
@@ -54,5 +53,5 @@
 				<MapControlZoom />
 			</MapControlGroup>
 		</Map>
-	</MapApp>
+	</div>
 </Story>