Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Removing allinone class #79

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Removing allinone class #79

wants to merge 2 commits into from

Conversation

avitacco
Copy link
Contributor

As discussed in issue #76, I am removing the allinone class and the associated unit test.

Notes for Reviewers

  • The commit history must be preserved - please use the rebase-merge or standard merge option instead of squash-merge
  • Sync up with the author before merging

@avitacco
Removing allinone class
26cbb7b 
As discussed in issue Graylog2#76, I am removing the allinone class and the
associated unit test.
bernd
bernd reviewed Jan 30, 2025
View reviewed changes
Copy link
Member

@bernd bernd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you! Can you also remove the test code in the tests/ folder and the Vagrantfilefile? I was using the code for manual testing with Vagrant. Since we now have the litmus tests, we don't need that anymore.

@bernd
Copy link
Member

bernd commented Jan 30, 2025

Oh, and please remove the allinone documentation from the README.md file. Thanks!

@avitacco
Copy link
Contributor Author

Absolutely! I'm sorry I didn't catch these things initially, especially updating the documentation.

@avitacco
Cleaning up some missed things
8576d60 
This commit removes Vagrant-based tests. It also updates the README file
to remove references to the allinone class. It also adds information
about how to test the code without the Vagrant-based tests.
@avitacco
Copy link
Contributor Author

I removed the Vagrant-based tests and the allinone documentation from the readme. I also added some info in the readme about how to test using pdk and litmus. I also added details for using pdk in the contributing file. I hope this is acceptable.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bernd bernd bernd left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@avitacco @bernd