Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Show version compatibility in migration list #20483

Merged
merged 1 commit into from
Sep 19, 2024

Conversation

moesterheld
Copy link
Contributor

Description

Adds a warning icon to any data nodes in the list of nodes in the migration wizard that are running incompatible versions (both on welcome page and corresponding lists in in-place and remote reindexing).
Also adds an alert above the list to make the user aware of the issue.

/nocl

Motivation and Context

fixes #20471

How Has This Been Tested?

Screenshots (if appropriate):

image

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Refactoring (non-breaking change)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.

Copy link
Contributor

@todvora todvora left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks for implementing this!

Copy link
Contributor

@gally47 gally47 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@gally47 gally47 merged commit a51d072 into master Sep 19, 2024
6 checks passed
@gally47 gally47 deleted the fix/20471-show-data-node-version-incompatiblity branch September 19, 2024 09:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Make user aware of data node / Graylog version incompatibility in migration wizard
3 participants