Gradwell changes to SipUnit #1
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… to be to do with the type of a 'Timestamp' Tested with java version "1.7.0_67" Java(TM) SE Runtime Environment (build 1.7.0_67-b01) Java HotSpot(TM) 64-Bit Server VM (build 24.65-b04, mixed mode)
Based on the following thread: https://sourceforge.net/p/cafesip/discussion/467762/thread/fbf155f6
target is now a version number.
…race support. Support user-defined log4j compatible logger - We needed to bump the log4j dependency on a bit for this support.
We're not entirely sure about this logic, but it prevented us seeing BYE requests between agents. The BYE was received, but waitForDisconnect() timed out. This change appears to correct it.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These are the changes I intend to submit to Mobicents - the new maintainer of the SipUnit project. This review is just to ensure the firm is happy with that request, before it goes for discussion by the upstream maintainer.