Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes dependencies + make compatible with https://github.com/opengovsg/mockpass #60

Open
wants to merge 5 commits into
base: master
Choose a base branch
from

Conversation

choonkeat-govtech
Copy link

before

$ npm audit
# npm audit report

semver  6.0.0 - 6.3.0 || 7.0.0 - 7.5.1
Severity: moderate
semver vulnerable to Regular Expression Denial of Service - https://github.com/advisories/GHSA-c2qf-rxjj-qqgw
semver vulnerable to Regular Expression Denial of Service - https://github.com/advisories/GHSA-c2qf-rxjj-qqgw
fix available via `npm audit fix`
node_modules/jest-snapshot/node_modules/semver
node_modules/jsonwebtoken/node_modules/semver
node_modules/semver
node_modules/ts-jest/node_modules/semver

word-wrap  <1.2.4
Severity: moderate
word-wrap vulnerable to Regular Expression Denial of Service - https://github.com/advisories/GHSA-j8xg-fqg3-53r7
fix available via `npm audit fix`
node_modules/word-wrap

2 moderate severity vulnerabilities

To address all issues, run:
  npm audit fix

after

$ npm audit
found 0 vulnerabilities

Copy link
Author

@choonkeat-govtech choonkeat-govtech left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

switch the package.json references back to GovTechSG
i'd needed to publish as my own package for use in my own app

Comment on lines +2 to +3
"name": "@choonkeat/singpass-myinfo-oidc-helper",
"version": "7.3.1",
Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

well, maybe to merge, switch this back

Suggested change
"name": "@choonkeat/singpass-myinfo-oidc-helper",
"version": "7.3.1",
"name": "@govtechsg/singpass-myinfo-oidc-helper",
"version": "7.3.1",

Comment on lines +7 to +8
"repository": "github:choonkeat-govtech/singpass-myinfo-oidc-helper",
"bugs": "https://github.com/choonkeat-govtech/singpass-myinfo-oidc-helper/issues",
Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
"repository": "github:choonkeat-govtech/singpass-myinfo-oidc-helper",
"bugs": "https://github.com/choonkeat-govtech/singpass-myinfo-oidc-helper/issues",
"repository": "github:GovTechSG/singpass-myinfo-oidc-helper",
"bugs": "https://github.com/GovTechSG/singpass-myinfo-oidc-helper/issues",

@Gyunikuchan Gyunikuchan mentioned this pull request Dec 6, 2023
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We'll be keeping proxy-agent as we may not be using TLS when hitting a local mock URL

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants