-
Notifications
You must be signed in to change notification settings - Fork 22
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixes dependencies + make compatible with https://github.com/opengovsg/mockpass #60
base: master
Are you sure you want to change the base?
Conversation
vm2 is a dependent of proxy-agent; use https-proxy-agent instead?
not wrong, but crashes destination if expressjs/body-parser#237 e.g. https://github.com/opengovsg/mockpass
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
switch the package.json references back to GovTechSG
i'd needed to publish as my own package for use in my own app
"name": "@choonkeat/singpass-myinfo-oidc-helper", | ||
"version": "7.3.1", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
well, maybe to merge, switch this back
"name": "@choonkeat/singpass-myinfo-oidc-helper", | |
"version": "7.3.1", | |
"name": "@govtechsg/singpass-myinfo-oidc-helper", | |
"version": "7.3.1", |
"repository": "github:choonkeat-govtech/singpass-myinfo-oidc-helper", | ||
"bugs": "https://github.com/choonkeat-govtech/singpass-myinfo-oidc-helper/issues", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
"repository": "github:choonkeat-govtech/singpass-myinfo-oidc-helper", | |
"bugs": "https://github.com/choonkeat-govtech/singpass-myinfo-oidc-helper/issues", | |
"repository": "github:GovTechSG/singpass-myinfo-oidc-helper", | |
"bugs": "https://github.com/GovTechSG/singpass-myinfo-oidc-helper/issues", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We'll be keeping proxy-agent
as we may not be using TLS when hitting a local mock URL
before
after