chore(appengine) Remove deprecated samples directory#13833
chore(appengine) Remove deprecated samples directory#13833XrossFox wants to merge 1 commit intoGoogleCloudPlatform:mainfrom
Conversation
Removal of appengine/flexible_python37_and_earlier path for deprecation. As per my search on Code Search, there are no samples using these deprecated code snippets anymore. b/475332253
Summary of ChangesHello @XrossFox, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request completes the final step in a deprecation process by removing all sample code and associated configuration files that supported Python 3.7 and earlier versions within the App Engine flexible environment. These samples were identified as no longer being used, and their removal simplifies the codebase and focuses resources on currently supported environments. Highlights
Changelog
Activity
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Code Review
This pull request removes the deprecated samples located in the appengine/flexible_python37_and_earlier directory. The changes are straightforward and align with the goal of removing outdated code. This is a good cleanup task.
I noticed that appengine/flexible/README.md still contains a reference to the deleted directory on lines 10-11. This will result in a broken link. I recommend creating a follow-up pull request to remove this reference.
The file deletions in this PR are correct.
Description
Removal of appengine/flexible_python37_and_earlier path for deprecation.
b/475332253
Note: Before submitting a pull request, please open an issue for discussion if you are not associated with Google.
Checklist
nox -s py-3.9(see Test Environment Setup)nox -s lint(see Test Environment Setup)