Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(deps): update dependency uuid to v9 #3009

Merged

Conversation

renovate-bot
Copy link
Contributor

@renovate-bot renovate-bot commented Jan 30, 2023

Mend Renovate

This PR contains the following updates:

Package Change Age Adoption Passing Confidence
uuid ^8.0.0 -> ^9.0.0 age adoption passing confidence

Release Notes

uuidjs/uuid

v9.0.0

Compare Source

⚠ BREAKING CHANGES
  • Drop Node.js 10.x support. This library always aims at supporting one EOLed LTS release which by this time now is 12.x which has reached EOL 30 Apr 2022.

  • Remove the minified UMD build from the package.

    Minified code is hard to audit and since this is a widely used library it seems more appropriate nowadays to optimize for auditability than to ship a legacy module format that, at best, serves educational purposes nowadays.

    For production browser use cases, users should be using a bundler. For educational purposes, today's online sandboxes like replit.com offer convenient ways to load npm modules, so the use case for UMD through repos like UNPKG or jsDelivr has largely vanished.

  • Drop IE 11 and Safari 10 support. Drop support for browsers that don't correctly implement const/let and default arguments, and no longer transpile the browser build to ES2015.

    This also removes the fallback on msCrypto instead of the crypto API.

    Browser tests are run in the first supported version of each supported browser and in the latest (as of this commit) version available on Browserstack.

Features
Bug Fixes
build
8.3.2 (2020-12-08)
Bug Fixes
8.3.1 (2020-10-04)
Bug Fixes

Configuration

📅 Schedule: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined).

🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.

Rebasing: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.

🔕 Ignore: Close this PR and you won't be reminded about these updates again.


  • If you want to rebase/retry this PR, check this box

This PR has been generated by Mend Renovate. View repository job log here.

@renovate-bot renovate-bot requested review from noerog, a team and ricalo as code owners January 30, 2023 02:30
@dpebot
Copy link
Contributor

dpebot commented Jan 30, 2023

/gcbrun

@product-auto-label product-auto-label bot added the samples Issues that are directly related to samples. label Jan 30, 2023
@trusted-contributions-gcf trusted-contributions-gcf bot added kokoro:force-run Add this label to force Kokoro to re-run the tests. actions:force-run labels Jan 30, 2023
@product-auto-label product-auto-label bot added the api: cloudfunctions Issues related to the Cloud Run functions API. label Jan 30, 2023
@kokoro-team kokoro-team removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Jan 30, 2023
@dpebot
Copy link
Contributor

dpebot commented Jan 30, 2023

/gcbrun

@trusted-contributions-gcf trusted-contributions-gcf bot added kokoro:force-run Add this label to force Kokoro to re-run the tests. actions:force-run labels Jan 30, 2023
@kokoro-team kokoro-team removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Jan 30, 2023
Copy link
Contributor

@Shnatsel Shnatsel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've reviewed the changelog for uuid and the changes look good to me.

However, CI is failing for Data Catalog, Cloud Functions and Healthcare:

Error: google-github-actions/auth failed with: retry function failed after 1 attempt: gitHub Actions did not inject $ACTIONS_ID_TOKEN_REQUEST_TOKEN or $ACTIONS_ID_TOKEN_REQUEST_URL into this job. This most likely means the GitHub Actions workflow permissions are incorrect, or this job is being run from a fork. For more information, please see https://docs.github.com/en/actions/security-guides/automatic-token-authentication#permissions-for-the-github_token

We'll need someone familiar with those products to take a look.

@kweinmeister
Copy link
Collaborator

FYI @Shnatsel That error is expected for dependency updates from a fork, rather than a branch. We can ignore failures that are of type pull_request only if the matching pull_request_target for that same service is passing.

There is an open issue to clean up the GitHub Actions workflow logic, so only the PR target check triggers in this scenario.

@Shnatsel
Copy link
Contributor

I see, thank you for clarifying. All pull_request_target checks are passing.

@dpebot
Copy link
Contributor

dpebot commented Jan 30, 2023

/gcbrun

@trusted-contributions-gcf trusted-contributions-gcf bot added kokoro:force-run Add this label to force Kokoro to re-run the tests. actions:force-run labels Jan 30, 2023
@kokoro-team kokoro-team removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Jan 30, 2023
@kweinmeister kweinmeister merged commit 8c70ce9 into GoogleCloudPlatform:main Jan 30, 2023
@renovate-bot renovate-bot deleted the renovate/uuid-9.x branch January 30, 2023 18:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api: cloudfunctions Issues related to the Cloud Run functions API. samples Issues that are directly related to samples.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants