Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Test needed for speech/infiniteStreaming.js #3271

Open
anguillanneuf opened this issue Jun 13, 2023 · 0 comments
Open

Test needed for speech/infiniteStreaming.js #3271

anguillanneuf opened this issue Jun 13, 2023 · 0 comments
Labels
priority: p3 Desirable enhancement or fix. May not be included in next release. samples Issues that are directly related to samples. type: cleanup An internal cleanup or hygiene concern.

Comments

@anguillanneuf
Copy link
Member

This sample is missing a test: https://github.com/GoogleCloudPlatform/nodejs-docs-samples/blob/main/speech/infiniteStreaming.js

The initial PR from years ago had no such requirement, which is no longer the case now.
@anguillanneuf anguillanneuf added type: feature request ‘Nice-to-have’ improvement, new feature or different behavior or design. triage me I really want to be triaged. priority: p3 Desirable enhancement or fix. May not be included in next release. labels Jun 13, 2023
@product-auto-label product-auto-label bot added the samples Issues that are directly related to samples. label Jun 13, 2023
@anguillanneuf anguillanneuf mentioned this issue Jun 13, 2023
Closed
11 tasks
@kweinmeister kweinmeister added type: cleanup An internal cleanup or hygiene concern. and removed triage me I really want to be triaged. type: feature request ‘Nice-to-have’ improvement, new feature or different behavior or design. labels Aug 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
priority: p3 Desirable enhancement or fix. May not be included in next release. samples Issues that are directly related to samples. type: cleanup An internal cleanup or hygiene concern.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@anguillanneuf @kweinmeister