-
Notifications
You must be signed in to change notification settings - Fork 2.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Create InfiniteStreamRecognizeSoftHandover.java #8251
Conversation
- Adding a sample for Soft Handover in stream switching. Please refer GoogleCloudPlatform#8250 for issue background.
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
Here is the summary of changes. You are about to add 1 region tag.
This comment is generated by snippet-bot.
|
Ran formatting with google-java-formatter.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please
- add a test
- move the region tag start tag to line 18 (to include imports in the displayed/published sample)
- can you link to where in the docs this sample will get published? have you checked with the tech writer?
Hello @anguillanneuf!
|
Thanks @bburli for providing the great context for your PR! I apologize that I only had a chance to read carefully through the links you provided today. I'm sorry what i'm about to tell you may disappoint you. I have provided some options for you to consider. This repo
I also saw your communication with @minherz. He and I are on the same team and I will follow up with him offline. A helpful sample is different from a sample that we are committed to maintain thus a sample we will publish on g.co/cloud. I would recommend that you publish it in a different venue.
In order to publish your sample here, you need to engage with the product team and the TW to plan it. If they approve and are committed to add a docs page or a section in the docs describing what this sample is and why, we will allow it, and we will at that point require this sample to have a test. |
@anguillanneuf Thank you so much for your guidance on this. I have a few questions:
Hi @anguillanneuf - Thank you for your guidance here. This helps.
|
@bburli I mistook you for a Googler who would have contact with the product team and their tech writer, ofc you would not know how to reach out, I'm sorry about that. Please ignore the last paragraph in my previous response. I saw your post in Google Cloud Community. Thanks a lot. I'm going to go ahead and close this PR and the related issue. |
Adding a sample for Soft Handover in stream switching.
Please refer #8250 for issue background.
Description
InfiniteStreamRecognize.java
class, except that it demonstrates how to perform "soft handover" between two streams.Fixes #8250
Note: Before submitting a pull request, please open an issue for discussion if you are not associated with Google.
Checklist
pom.xml
parent set to latestshared-configuration
mvn clean verify
requiredmvn -P lint checkstyle:check
requiredmvn -P lint clean compile pmd:cpd-check spotbugs:check
advisory only