Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Running GitHub Workflows duplicate events: push and pull_request #2891

Open
grayside opened this issue Nov 29, 2022 · 0 comments
Open

Running GitHub Workflows duplicate events: push and pull_request #2891

grayside opened this issue Nov 29, 2022 · 0 comments
Assignees
Labels
priority: p2 Moderately-important priority. Fix may not be included in next release. samples Issues that are directly related to samples. type: cleanup An internal cleanup or hygiene concern.

Comments

@grayside
Copy link
Collaborator

The GitHub Workflow template runs for each set of samples on push and pull_request.

Based on my reading of the syntax documentation, pull_request is necessary for forks.

It looks like folks contributing from a branch in the repository would trigger duplicate tests. Looking at some data, I don't see signs of duplicate work but documented points like https://docs.github.com/en/actions/using-workflows/triggering-a-workflow#using-multiple-events indicate that there should be.

Action Items from this issue should be one of:

  • Removing push as an event trigger from each config and the template
  • Adding an in-line comment to each config and the template explaining why we use both

@sofisl could you provide some insight into why we have both triggering events in the config?

@grayside grayside self-assigned this Nov 29, 2022
@product-auto-label product-auto-label bot added the samples Issues that are directly related to samples. label Nov 29, 2022
@kweinmeister kweinmeister added type: cleanup An internal cleanup or hygiene concern. priority: p2 Moderately-important priority. Fix may not be included in next release. labels Jan 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
priority: p2 Moderately-important priority. Fix may not be included in next release. samples Issues that are directly related to samples. type: cleanup An internal cleanup or hygiene concern.
Projects
None yet
Development

No branches or pull requests

3 participants