-
Notifications
You must be signed in to change notification settings - Fork 7.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Base resource requests on actual usage #2540
base: main
Are you sure you want to change the base?
Conversation
🚲 PR staged at http://34.42.127.234 |
🚲 PR staged at http://34.42.127.234 |
🚲 PR staged at http://34.42.127.234 |
🚲 PR staged at http://34.42.127.234 |
cpu: 200m | ||
memory: 450Mi | ||
cpu: 30m | ||
memory: 30Mi |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Getting OOMKilled
with this on a brand new Kind cluster locally, let's have 70Mi
in limits
and 50Mi
in requests
like the other Python app emailservice
has?
FYI: I just deployed this in my own GKE Autopilot cluster, and I'm getting these values,
In addition to the comment on the
Should we have:
|
🚲 PR staged at http://34.42.127.234 |
@NimJay do you remember where this PR was left off? |
Background
10m
(for CPU) and the next10MiB
for memory — to add a buffer.Change Summary
resource.requests.cpu
andresource.requests.memory
values of each default microservices's Deployment.Testing Procedure