Skip to content

Conversation

@melinath
Copy link
Member

@melinath melinath commented Jan 14, 2026

This ensures that the metadata for the impacted fields is correct - specifically, making sure that the api field name doesn't incorrectly contain an _ character.

Note that the value passed to the id_from_name flattener is ignored: https://github.com/GoogleCloudPlatform/magic-modules/blob/main/mmv1/templates/terraform/custom_flatten/id_from_name.tmpl

Release Note Template for Downstream PRs (will be copied)

See Write release notes for guidance.


@modular-magician

This comment was marked as outdated.

@modular-magician

This comment was marked as outdated.

@modular-magician

This comment was marked as outdated.

@melinath melinath force-pushed the id-from-name-api-name branch from 8197e2b to 0130039 Compare January 14, 2026 23:33
@melinath melinath changed the title Marked api_name: name for fields that use id_from_name flattener Fixed metadata for some fields that use id_from_name flattener Jan 14, 2026
@modular-magician
Copy link
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 2 files changed, 6 insertions(+), 6 deletions(-))
google-beta provider: Diff ( 6 files changed, 14 insertions(+), 12 deletions(-))
terraform-google-conversion: Diff ( 1 file changed, 3 insertions(+), 3 deletions(-))

@modular-magician
Copy link
Collaborator

Tests analytics

Total tests: 38
Passed tests: 23
Skipped tests: 3
Affected tests: 12

Click here to see the affected service packages
  • bigqueryconnection
  • firebasehosting

Action taken

Found 12 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests
  • TestAccBigqueryConnectionConnectionIamBindingGenerated
  • TestAccBigqueryConnectionConnectionIamMemberGenerated
  • TestAccBigqueryConnectionConnectionIamPolicyGenerated
  • TestAccBigqueryConnectionConnection_bigqueryConnectionAwsExample
  • TestAccBigqueryConnectionConnection_bigqueryConnectionAwsUpdate
  • TestAccBigqueryConnectionConnection_bigqueryConnectionAzureExample
  • TestAccBigqueryConnectionConnection_bigqueryConnectionCloudResourceExample
  • TestAccBigqueryConnectionConnection_bigqueryConnectionCloudSpannerDataBoostWithParallelism
  • TestAccBigqueryConnectionConnection_bigqueryConnectionCloudSpannerServerlessAnalyticsToDataBoostUpdate
  • TestAccBigqueryConnectionConnection_bigqueryConnectionCloudspannerDataboostExample
  • TestAccBigqueryConnectionConnection_bigqueryConnectionCloudspannerExample
  • TestAccBigqueryConnectionConnection_bigqueryConnectionSparkExample

Get to know how VCR tests work

@modular-magician
Copy link
Collaborator

🟢 Tests passed during RECORDING mode:
TestAccBigqueryConnectionConnectionIamBindingGenerated [Debug log]
TestAccBigqueryConnectionConnectionIamMemberGenerated [Debug log]
TestAccBigqueryConnectionConnectionIamPolicyGenerated [Debug log]
TestAccBigqueryConnectionConnection_bigqueryConnectionAwsExample [Debug log]
TestAccBigqueryConnectionConnection_bigqueryConnectionAwsUpdate [Debug log]
TestAccBigqueryConnectionConnection_bigqueryConnectionAzureExample [Debug log]
TestAccBigqueryConnectionConnection_bigqueryConnectionCloudResourceExample [Debug log]
TestAccBigqueryConnectionConnection_bigqueryConnectionCloudSpannerDataBoostWithParallelism [Debug log]
TestAccBigqueryConnectionConnection_bigqueryConnectionCloudSpannerServerlessAnalyticsToDataBoostUpdate [Debug log]
TestAccBigqueryConnectionConnection_bigqueryConnectionCloudspannerDataboostExample [Debug log]
TestAccBigqueryConnectionConnection_bigqueryConnectionCloudspannerExample [Debug log]
TestAccBigqueryConnectionConnection_bigqueryConnectionSparkExample [Debug log]

🟢 No issues found for passed tests after REPLAYING rerun.


🟢 All tests passed!

View the build log or the debug log for each test

@melinath melinath requested a review from zli82016 January 15, 2026 00:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants