Rename google_compute_interconnect_attachment_group.logicalStructure.regions.metros.facilities.zones.interconnect

[abhijeetkjha-google]

compute: added `interconnects` field to `google_compute_interconnect_attachment_group. logicalStructure.regions.metros.facilities.zones` and deprecated `interconnect` field

there was a typo in the initial implementation; the field was called attachment instead of attachments in the MMv1 yaml. There are two parts to this work:

Add the new field & deprecate the old field
Remove the old field in a major release
Docs: https://googlecloudplatform.github.io/magic-modules/breaking-changes/make-a-breaking-change/

[modular-magician]

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 3 files changed, 27 insertions(+), 2 deletions(-))
google-beta provider: Diff ( 3 files changed, 27 insertions(+), 2 deletions(-))

[modular-magician]

Tests analytics

Total tests: 1325
Passed tests: 1239
Skipped tests: 86
Affected tests: 0

Click here to see the affected service packages

• compute

🟢 All tests passed!

View the build log

[github-actions]

Hello! I am a robot. Tests will require approval from a repository maintainer to run.

Googlers: For automatic test runs see go/terraform-auto-test-runs.

@malhotrasagar2212, a repository maintainer, has been assigned to review your changes. If you have not received review feedback within 2 business days, please leave a comment on this PR asking them to take a look.

You can help make sure that review is quick by doing a self-review and by running impacted tests locally.

[malhotrasagar2212]

Hi @abhijeetkjha-google , this looks good to me. Just a suggestion, the PR description is clear on attachment-> attachments. But the PR title and release note mentions interconnect, which is a bit misleading- would you mind tweaking it to reference the attachments for easier history scanning? Thanks