Skip to content

Conversation

@MikolajLuczko
Copy link

Fixes hashicorp/terraform-provider-google#25771

Rollout sequencing with custom stages is now available in Public Preview (https://docs.cloud.google.com/kubernetes-engine/docs/concepts/rollout-sequencing-custom-stages/about-rollout-sequencing). Terraform support should be added for the Rollout Sequence resource, for now to the google-beta provider only.

Release Note Template for Downstream PRs (will be copied)

`google_gke_hub_rollout_sequence` (beta)

@github-actions github-actions bot requested a review from slevenick January 14, 2026 10:43
@github-actions
Copy link

Hello! I am a robot. Tests will require approval from a repository maintainer to run.

Googlers: For automatic test runs see go/terraform-auto-test-runs.

@slevenick, a repository maintainer, has been assigned to review your changes. If you have not received review feedback within 2 business days, please leave a comment on this PR asking them to take a look.

You can help make sure that review is quick by doing a self-review and by running impacted tests locally.

@modular-magician
Copy link
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 2 files changed, 291 insertions(+))
google-beta provider: Diff ( 6 files changed, 1300 insertions(+), 2 deletions(-))
terraform-google-conversion: Diff ( 1 file changed, 221 insertions(+))

@modular-magician
Copy link
Collaborator

Tests analytics

Total tests: 28
Passed tests: 22
Skipped tests: 5
Affected tests: 1

Click here to see the affected service packages
  • gkehub2

Action taken

Found 1 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests
  • TestAccGKEHub2RolloutSequence

Get to know how VCR tests work

@modular-magician
Copy link
Collaborator

🟢 Tests passed during RECORDING mode:
TestAccGKEHub2RolloutSequence [Debug log]

🟢 No issues found for passed tests after REPLAYING rerun.


🟢 All tests passed!

View the build log or the debug log for each test

@modular-magician
Copy link
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 2 files changed, 291 insertions(+))
google-beta provider: Diff ( 6 files changed, 1300 insertions(+), 2 deletions(-))
terraform-google-conversion: Diff ( 1 file changed, 221 insertions(+))

@modular-magician
Copy link
Collaborator

Tests analytics

Total tests: 28
Passed tests: 23
Skipped tests: 5
Affected tests: 0

Click here to see the affected service packages
  • gkehub2

🟢 All tests passed!

View the build log

@modular-magician
Copy link
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 2 files changed, 178 insertions(+))
google-beta provider: Diff ( 6 files changed, 1284 insertions(+), 2 deletions(-))
terraform-google-conversion: Diff ( 1 file changed, 221 insertions(+))

Errors

google-beta provider:

  • The diff processor failed to build. This is usually due to the downstream provider failing to compile.

@modular-magician
Copy link
Collaborator

Non-exercised tests

🔴 Tests were added that are skipped in VCR:

  • TestAccGKEHub2RolloutSequence

Tests analytics

Total tests: 0
Passed tests: 0
Skipped tests: 0
Affected tests: 0

Click here to see the affected service packages
  • gkehub2

🔴 Errors occurred during REPLAYING mode. Please fix them to complete your PR.

View the build log

@modular-magician
Copy link
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 2 files changed, 211 insertions(+))
google-beta provider: Diff ( 6 files changed, 1281 insertions(+), 2 deletions(-))
terraform-google-conversion: Diff ( 1 file changed, 221 insertions(+))

Errors

google-beta provider:

  • The diff processor failed to build. This is usually due to the downstream provider failing to compile.

@modular-magician
Copy link
Collaborator

Tests analytics

Total tests: 0
Passed tests: 0
Skipped tests: 0
Affected tests: 0

Click here to see the affected service packages
  • gkehub2

🔴 Errors occurred during REPLAYING mode. Please fix them to complete your PR.

View the build log

@modular-magician
Copy link
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 2 files changed, 211 insertions(+))
google-beta provider: Diff ( 6 files changed, 1281 insertions(+), 2 deletions(-))
terraform-google-conversion: Diff ( 1 file changed, 221 insertions(+))

Errors

google-beta provider:

  • The diff processor failed to build. This is usually due to the downstream provider failing to compile.

@modular-magician
Copy link
Collaborator

Tests analytics

Total tests: 0
Passed tests: 0
Skipped tests: 0
Affected tests: 0

Click here to see the affected service packages
  • gkehub2

🔴 Errors occurred during REPLAYING mode. Please fix them to complete your PR.

View the build log

@modular-magician
Copy link
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 2 files changed, 178 insertions(+))
google-beta provider: Diff ( 6 files changed, 1299 insertions(+), 2 deletions(-))
terraform-google-conversion: Diff ( 1 file changed, 221 insertions(+))

@modular-magician
Copy link
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 2 files changed, 178 insertions(+))
google-beta provider: Diff ( 6 files changed, 1299 insertions(+), 2 deletions(-))
terraform-google-conversion: Diff ( 1 file changed, 221 insertions(+))

@modular-magician
Copy link
Collaborator

Tests analytics

Total tests: 28
Passed tests: 23
Skipped tests: 5
Affected tests: 0

Click here to see the affected service packages
  • gkehub2

🟢 All tests passed!

View the build log

@modular-magician
Copy link
Collaborator

Tests analytics

Total tests: 28
Passed tests: 23
Skipped tests: 5
Affected tests: 0

Click here to see the affected service packages
  • gkehub2

🟢 All tests passed!

View the build log

'Rollout Sequencing Overview': 'https://cloud.google.com/kubernetes-engine/docs/concepts/rollout-sequencing-custom-stages/about-rollout-sequencing'
api: https://docs.cloud.google.com/kubernetes-engine/fleet-management/docs/reference/rest/v1beta/projects.locations.rolloutSequences
id_format: 'projects/{{project}}/locations/global/rolloutSequences/{{rollout_sequence_id}}'
base_url: 'projects/{{project}}/locations/global/rolloutSequences'
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is hard-coded to global, is that the only possible location forever?

If not, we should make location a parameter

Filter to select a subset of clusters from the specified Fleet projects.
If not specified, all clusters in the fleet projects are selected.
properties:
- name: 'labelSelector'
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should be required I think?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add Terraform support for the Rollout Sequence resource

3 participants