Skip to content

Conversation

@abhijeetkjha-google
Copy link
Contributor

compute: adding support for new spoke fields `exclude_import_ranges`, `include_export_ranges`, `exclude_export_ranges` and expanded CIDR support for `include_import_ranges`

Implemented support for the new spoke fields:

  • exclude_import_ranges
  • include_export_ranges
  • exclude_export_ranges
  • Expanded CIDR support for include_import_ranges

@modular-magician
Copy link
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 4 files changed, 305 insertions(+), 16 deletions(-))
google-beta provider: Diff ( 4 files changed, 305 insertions(+), 16 deletions(-))
terraform-google-conversion: Diff ( 1 file changed, 99 insertions(+))

@modular-magician
Copy link
Collaborator

Tests analytics

Total tests: 33
Passed tests: 28
Skipped tests: 1
Affected tests: 4

Click here to see the affected service packages
  • networkconnectivity

Action taken

Found 4 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests
  • TestAccNetworkConnectivitySpoke_InterconnectAttachmentHandWrittenHandWritten
  • TestAccNetworkConnectivitySpoke_RouterApplianceHandWritten
  • TestAccNetworkConnectivitySpoke_RouterApplianceHandWrittenLongForm
  • TestAccNetworkConnectivitySpoke_VPNTunnelHandWrittenHandWritten

Get to know how VCR tests work

@modular-magician
Copy link
Collaborator

🟢 Tests passed during RECORDING mode:
TestAccNetworkConnectivitySpoke_RouterApplianceHandWritten [Debug log]

🟢 No issues found for passed tests after REPLAYING rerun.


🔴 Tests failed during RECORDING mode:
TestAccNetworkConnectivitySpoke_InterconnectAttachmentHandWrittenHandWritten [Error message] [Debug log]
TestAccNetworkConnectivitySpoke_RouterApplianceHandWrittenLongForm [Error message] [Debug log]
TestAccNetworkConnectivitySpoke_VPNTunnelHandWrittenHandWritten [Error message] [Debug log]

🔴 Errors occurred during RECORDING mode. Please fix them to complete your PR.

View the build log or the debug log for each test

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants