Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cloudfunctions: bootstraped IAM roles for service agent #12806

Merged
merged 1 commit into from
Jan 24, 2025

Conversation

wyardley
Copy link
Contributor

@wyardley wyardley commented Jan 19, 2025

Bootstrap IAM role for service-[project_number]@gcf-admin-robot.iam.gserviceaccount.com to avoid having bindings get deleted when tests run in parallel.

Also adjust role(s) assigned to service agent.

Fixes hashicorp/terraform-provider-google#20570

Uses new bootstrapping utility from #12796

Release Note Template for Downstream PRs (will be copied)

See Write release notes for guidance.


Bootstrap IAM role for
`service-[project_number]@gcf-admin-robot.iam.gserviceaccount.com` to
avoid having bindings get deleted when tests run in parallel.

Also adjust role(s) assigned to service agent.

Fixes hashicorp/terraform-provider-google#20570
@github-actions github-actions bot requested a review from slevenick January 19, 2025 09:00
Copy link

Hello! I am a robot. Tests will require approval from a repository maintainer to run.

@slevenick, a repository maintainer, has been assigned to review your changes. If you have not received review feedback within 2 business days, please leave a comment on this PR asking them to take a look.

You can help make sure that review is quick by doing a self-review and by running impacted tests locally.

@modular-magician modular-magician added the awaiting-approval Pull requests that need reviewer's approval to run presubmit tests label Jan 19, 2025
Copy link

@slevenick This PR has been waiting for review for 3 weekdays. Please take a look! Use the label disable-review-reminders to disable these notifications.

@modular-magician modular-magician added service/cloudfunctions and removed awaiting-approval Pull requests that need reviewer's approval to run presubmit tests labels Jan 24, 2025
@modular-magician
Copy link
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 1 file changed, 19 insertions(+), 26 deletions(-))
google-beta provider: Diff ( 1 file changed, 19 insertions(+), 26 deletions(-))

@modular-magician
Copy link
Collaborator

Tests analytics

Total tests: 19
Passed tests: 16
Skipped tests: 2
Affected tests: 1

Click here to see the affected service packages
  • cloudfunctions

Action taken

Found 1 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests
  • TestAccCloudFunctionsFunction_vpcConnectorEgressSettings

Get to know how VCR tests work

@modular-magician
Copy link
Collaborator

🟢 Tests passed during RECORDING mode:
TestAccCloudFunctionsFunction_vpcConnectorEgressSettings [Debug log]

🟢 No issues found for passed tests after REPLAYING rerun.


🟢 All tests passed!

View the build log or the debug log for each test

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Failing test(s): TestAccCloudFunctionsFunction_vpcConnectorEgressSettings
3 participants