Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix failing TestAccDataflowJob tests. #12798

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

damondouglas
Copy link
Contributor

This PR fixes hashicorp/terraform-provider-google#18074 largely changing the use of the Projects.Jobs.Get to the recommended Projects.Locations.Jobs.Get which is based on the regional endpoints.


@github-actions github-actions bot requested a review from shuyama1 January 18, 2025 00:38
Copy link

Hello! I am a robot. Tests will require approval from a repository maintainer to run.

@shuyama1, a repository maintainer, has been assigned to review your changes. If you have not received review feedback within 2 business days, please leave a comment on this PR asking them to take a look.

You can help make sure that review is quick by doing a self-review and by running impacted tests locally.

@modular-magician
Copy link
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 1 file changed, 208 insertions(+), 155 deletions(-))
google-beta provider: Diff ( 1 file changed, 208 insertions(+), 155 deletions(-))

@modular-magician
Copy link
Collaborator

Tests analytics

Total tests: 25
Passed tests: 0
Skipped tests: 25
Affected tests: 0

Click here to see the affected service packages
  • dataflow

🟢 All tests passed!

View the build log

@shuyama1
Copy link
Member

Triggered tests that skipped in VCR on TC. I'll update test result here after they're done

Copy link

@shuyama1 This PR has been waiting for review for 3 weekdays. Please take a look! Use the label disable-review-reminders to disable these notifications.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Failing test(s): TestAccDataflowJob*
3 participants