Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(cloudrun): migrate region "cloudrun_pubsub_dockerfile" from run/pubsub/Dockerfile #5118

Conversation

OremGLG
Copy link
Contributor

@OremGLG OremGLG commented Jan 31, 2025

Description

In order to align to pattern "product_region_tag_typeoffile_language" decided to migrate region "cloudrun_pubsub_dockerfile" to "cloudrun_pubsub_dockerfile_go"

Fixes
b/388068402

Note: Before submitting a pull request, please open an issue for discussion if you are not associated with Google.

Checklist

  • I have followed Contributing Guidelines from CONTRIBUTING.MD
  • Tests pass: go test -v ./.. (see Testing)
  • Code formatted: gofmt (see Formatting)
  • Vetting pass: go vet (see Formatting)
  • These samples need a new API enabled in testing projects to pass (let us know which ones)
  • These samples need a new/updated env vars in testing projects set to pass (let us know which ones)
  • This sample adds a new sample directory, and I updated the CODEOWNERS file with the codeowners for this sample
  • This sample adds a new Product API, and I updated the Blunderbuss issue/PR auto-assigner with the codeowners for this sample
  • Please merge this PR for me once it is approved

@product-auto-label product-auto-label bot added the samples Issues that are directly related to samples. label Jan 31, 2025
Copy link

@code-review-assist code-review-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi team,

I'm currently reviewing this pull request and will have a full review in a few minutes. In the meantime, here's a quick summary for you and other reviewers to get up to speed:

This pull request, submitted by OremGLG, aims to migrate the region tag in the cloudrun_pubsub_dockerfile from run/pubsub/Dockerfile to align with the new naming pattern: product_region_tag_typeoffile_language. Specifically, the change renames it to cloudrun_pubsub_dockerfile_go.

Here's a breakdown of the changes:

  • Files Changed:

    • run/pubsub/Dockerfile:
      • The # [START cloudrun_pubsub_dockerfile] and # [END cloudrun_pubsub_dockerfile] comments were modified to include the new _go suffix (lines 15-16 and 51-52). The addition of # [START cloudrun_pubsub_dockerfile_go] and # [END cloudrun_pubsub_dockerfile_go] comments were added on lines 15 and 53 respectively.
  • Intent: To standardize the naming convention for Dockerfiles across the project, improving consistency and maintainability.

  • Associated Issue: b/388068402

The author has indicated that tests have passed, and the code has been formatted and vetted. However, please ensure to double-check these aspects as part of your review.


A little poem to brighten your day:

A Dockerfile's name,
Changed with care, a new design,
Code flows smoothly on.

Looking forward to your feedback!

Best,
Gemini

Copy link

@code-review-assist code-review-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This pull request migrates the region tag "cloudrun_pubsub_dockerfile" to follow the pattern "product_region_tag_typeoffile_language", resulting in the new tag "cloudrun_pubsub_dockerfile_go". This change improves consistency and clarity in tagging Dockerfiles.

I noticed that the checklist items related to testing, formatting, and vetting are not checked. Please ensure these steps are completed before merging. Additionally, consider adding a small description of this change to the README file to keep the documentation up-to-date.

@OremGLG OremGLG marked this pull request as ready for review January 31, 2025 16:12
@OremGLG OremGLG requested review from a team as code owners January 31, 2025 16:12
Copy link

snippet-bot bot commented Jan 31, 2025

Here is the summary of changes.

You are about to add 1 region tag.

This comment is generated by snippet-bot.
If you find problems with this result, please file an issue at:
https://github.com/googleapis/repo-automation-bots/issues.
To update this comment, add snippet-bot:force-run label or use the checkbox below:

  • Refresh this comment

@telpirion telpirion self-assigned this Feb 4, 2025
@telpirion telpirion merged commit 53f616b into GoogleCloudPlatform:main Feb 4, 2025
8 of 9 checks passed
@OremGLG OremGLG deleted the garciadiaz-chore-migrate-region-388068402 branch February 4, 2025 17:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
samples Issues that are directly related to samples.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants