Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(cloudrun): delete old region tag "run_imageproc_dockerfile_imagemagick" #5114

Conversation

OremGLG
Copy link
Contributor

@OremGLG OremGLG commented Jan 29, 2025

Description

Delete old region tag "run_imageproc_dockerfile_imagemagick"

Fixes
b/347347989

Note: Before submitting a pull request, please open an issue for discussion if you are not associated with Google.

Checklist

  • I have followed Contributing Guidelines from CONTRIBUTING.MD
  • Tests pass: go test -v ./.. (see Testing)
  • Code formatted: gofmt (see Formatting)
  • Vetting pass: go vet (see Formatting)
  • These samples need a new API enabled in testing projects to pass (let us know which ones)
  • These samples need a new/updated env vars in testing projects set to pass (let us know which ones)
  • This sample adds a new sample directory, and I updated the CODEOWNERS file with the codeowners for this sample
  • This sample adds a new Product API, and I updated the Blunderbuss issue/PR auto-assigner with the codeowners for this sample
  • Please merge this PR for me once it is approved

@product-auto-label product-auto-label bot added the samples Issues that are directly related to samples. label Jan 29, 2025
Copy link

@code-review-assist code-review-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi team,

I'm currently reviewing this pull request and will provide a full review shortly. In the meantime, here's a quick summary for you and other reviewers to get up to speed:

This pull request, submitted by OremGLG, aims to delete the outdated region tag run_imageproc_dockerfile_imagemagick from the run/image-processing/Dockerfile. The change addresses issue b/347347989.

Here's a breakdown of the changes:

  • File Changed: run/image-processing/Dockerfile
  • Change Summary: Removed lines 40 and 47, which contained the outdated region tag. This simplifies the Dockerfile and removes unnecessary comments.

The specific lines removed are:

- # [START run_imageproc_dockerfile_imagemagick]
- # [END run_imageproc_dockerfile_imagemagick]

Before:

37:FROM alpine:3
38:
39:# [START cloudrun_imageproc_dockerfile_imagemagick]
40:# [START run_imageproc_dockerfile_imagemagick]
41:
42:# Install Imagemagick into the container image.
43:# For more on system packages review the system packages tutorial.
44:# https://cloud.google.com/run/docs/tutorials/system-packages#dockerfile
45:RUN apk add --no-cache imagemagick
46:
47:# [END run_imageproc_dockerfile_imagemagick]
48:# [END cloudrun_imageproc_dockerfile_imagemagick]
49:
50:# Install certificates for secure communication with network services.

After:

37:FROM alpine:3
38:
39:# [START cloudrun_imageproc_dockerfile_imagemagick]
40:
41:# Install Imagemagick into the container image.
42:# For more on system packages review the system packages tutorial.
43:# https://cloud.google.com/run/docs/tutorials/system-packages#dockerfile
44:RUN apk add --no-cache imagemagick
45:
46:# [END cloudrun_imageproc_dockerfile_imagemagick]
47:
48:# Install certificates for secure communication with network services.

I'll be back with a more detailed review shortly.


A little haiku to brighten your day:

Code flows like a stream,
Cleaning up, a gentle hand,
Fresh code, pure and bright.

Copy link

Gemini encountered an error creating the review. You can try again by commenting @code-review-assist review.

@OremGLG OremGLG marked this pull request as ready for review January 29, 2025 21:59
@OremGLG OremGLG requested review from a team as code owners January 29, 2025 21:59
Copy link

snippet-bot bot commented Jan 29, 2025

Here is the summary of changes.

You are about to delete 1 region tag.

This comment is generated by snippet-bot.
If you find problems with this result, please file an issue at:
https://github.com/googleapis/repo-automation-bots/issues.
To update this comment, add snippet-bot:force-run label or use the checkbox below:

  • Refresh this comment

@telpirion telpirion self-assigned this Jan 30, 2025
@telpirion telpirion merged commit 6421203 into GoogleCloudPlatform:main Feb 4, 2025
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
samples Issues that are directly related to samples.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants