Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor write failure composite tests #2854

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

vipnydav
Copy link
Member

@vipnydav vipnydav commented Jan 3, 2025

Description

Refactored write failure composite tests to have a single file for common tests of local inode and synced file and fixed dangling pointer issue in TestUnlinkedDirectoryContainingSyncedAndLocalFilesCloseThrowsStaleFileHandleError.

Link to the issue in case of a bug fix.

NA

Testing details

  1. Manual - Done
  2. Unit tests - NA
  3. Integration tests - NA

@vipnydav vipnydav requested a review from ashmeenkaur January 3, 2025 07:27
@vipnydav vipnydav requested a review from a team as a code owner January 3, 2025 07:28
@kislaykishore kislaykishore requested review from a team and tritone and removed request for a team January 3, 2025 07:28
Copy link

codecov bot commented Jan 3, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 76.07%. Comparing base (4a31463) to head (1b6e3b5).
Report is 1 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2854      +/-   ##
==========================================
- Coverage   76.11%   76.07%   -0.05%     
==========================================
  Files         118      118              
  Lines       16557    16557              
==========================================
- Hits        12603    12596       -7     
- Misses       3423     3430       +7     
  Partials      531      531              
Flag Coverage Δ
unittests 76.07% <ø> (-0.05%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant