Fix kernel cache ttl test failure for GKE #2853
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #2853 +/- ##
==========================================
+ Coverage 76.08% 76.11% +0.03%
==========================================
Files 118 118
Lines 16557 16557
==========================================
+ Hits 12598 12603 +5
+ Misses 3427 3423 -4
+ Partials 532 531 -1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
kislaykishore
requested review from
a team,
BrennaEpp and
gargnitingoogle
and removed request for
a team and
BrennaEpp
raj-prince
reviewed
Jan 3, 2025
tools/integration_tests/kernel_list_cache/infinite_kernel_list_cache_deletion_test.go
Outdated
Show resolved
Hide resolved
raj-prince
approved these changes
Jan 3, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Tests began failing due to execution sequence issues stemming from the addition of a negative cache upon deletion. To address this, the affected tests were moved to a separate file and configured with a metadata cache TTL of 0.
Link to the issue in case of a bug fix.
b/386817041
Testing details