Add Integration Tests for Write Failure Improvements #2845
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kislaykishore
requested review from
a team,
BrennaEpp,
gargnitingoogle and
tritone
and removed request for
a team,
BrennaEpp and
gargnitingoogle
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #2845 +/- ##
==========================================
+ Coverage 76.05% 76.11% +0.06%
==========================================
Files 118 118
Lines 16456 16557 +101
==========================================
+ Hits 12515 12603 +88
- Misses 3412 3423 +11
- Partials 529 531 +2
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
ashmeenkaur
reviewed
Dec 31, 2024
tools/integration_tests/stale_handle/stale_file_handle_local_file_test.go
Outdated
Show resolved
Hide resolved
tools/integration_tests/stale_handle/stale_file_handle_local_file_test.go
Outdated
Show resolved
Hide resolved
tools/integration_tests/stale_handle/stale_file_handle_local_file_test.go
Show resolved
Hide resolved
tools/integration_tests/stale_handle/stale_file_handle_synced_file_test.go
Outdated
Show resolved
Hide resolved
tools/integration_tests/stale_handle/stale_file_handle_synced_file_test.go
Outdated
Show resolved
Hide resolved
tools/integration_tests/stale_handle/stale_file_handle_synced_file_test.go
Outdated
Show resolved
Hide resolved
tools/integration_tests/stale_handle/stale_file_handle_synced_file_test.go
Outdated
Show resolved
Hide resolved
tools/integration_tests/stale_handle/stale_file_handle_synced_file_test.go
Outdated
Show resolved
Hide resolved
Co-authored-by: Ashmeen Kaur <[email protected]>
…and moved commom parts of test to SetupTest
ashmeenkaur
reviewed
Jan 3, 2025
tools/integration_tests/stale_handle/stale_file_handle_common_test.go
Outdated
Show resolved
Hide resolved
tools/integration_tests/stale_handle/stale_file_handle_synced_file_test.go
Outdated
Show resolved
Hide resolved
tools/integration_tests/stale_handle/stale_file_handle_local_file_test.go
Outdated
Show resolved
Hide resolved
tools/integration_tests/stale_handle/stale_file_handle_synced_file_test.go
Outdated
Show resolved
Hide resolved
ashmeenkaur
reviewed
Jan 3, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR includes Integration tests for Write Failure Experience for the following scenarios:
Link to the issue in case of a bug fix.
https://b.corp.google.com/issues/365702002
https://b.corp.google.com/issues/365702723
Testing details