Add Google Cloud NetApp Volumes support #4583
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello,
here is a PR to add support for Google Cloud NetApp Volume, which provides NFS/SMB shared file-system.
It has two new modules:
The PR contains code and documentation for the two new modules, an example blueprint and updates to the blueprint readme and network_storage.md.
I am unsure if this needs to be a community contribution or a core one. GCNV is a Google first party service and I am part of the GCNV product team. So I consider it "core" contribution, but in the end it depends on how the CT team defines core vs community. Please advise.
I also need guidance if I need to add tests.
Looking forward to the review process.