Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[bigquery] only check build image on successful build #211

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

andrewmackett
Copy link

We were seeing unsuccessful Cloud Builds that have the images field defined were creating an error in the BigQuery notifier.

E1114 12:05:43.832522       1 notifiers.go:556] failed to run SendNotification: error parsing image manifest: error obtaining image reference: GET https://gcr.io/v2/project-id/image/manifests/tag: MANIFEST_UNKNOWN: Failed to fetch "tag"

We wouldn't expect the image to have been pushed to the repository in an unsuccessful build, so there will be no manifest for the notifier to lookup, causing the error.

This change executes the build image logic only if the build was successful.

@chitrangpatel
Copy link

/gcbrun

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants