Azure check policy relaxation #6353
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hubatish
approved these changes
Jan 14, 2026
Collaborator
hubatish
left a comment
hubatish
left a comment
There was a problem hiding this comment.
Thanks for the fix! Hopefully this contains the errors to one spot.
| [ | ||
| FLAGS.kubectl, | ||
| '--kubeconfig', | ||
| FLAGS.kubeconfig, |
Collaborator
There was a problem hiding this comment.
Use RunKubectlCommand rather than specifying FLAGS.kubectl & FLAGS.kubeconfig.
| self._RelaxAKSPolicy() | ||
| self._GetCredentials(use_admin=False) | ||
| self._WaitForDefaultServiceAccount() | ||
| self._WaitForPolicyRelaxation() |
Collaborator
There was a problem hiding this comment.
can this go at the end after _AttachContainerRegistry? Just to save a little time waiting while the latter command runs. Or do you think AttachContainerRegistry can also run into policy errors?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add the
_WaitForPolicyRelaxationmethod to ensure policy relaxation takes effectThe constraints for Resource Requests, Probes, and Image Tags are all part of the same "Safeguards" policy initiative and are bundled together in the Azure Policy assignment. Therefore, it is sufficient to check just one constraint. If the cluster update for the "Resource Requests" constraint is applied, the updates for "Probes" and "Image Tag" constraints are also included, as they are processed in the same transaction.
This method works by monitoring the
K8sAzureV1ContainerRequestsconstraint and waiting for its status to switch fromdenytodryrun.