Skip to content

Conversation

@danleh
Copy link
Collaborator

@danleh danleh commented Feb 7, 2026

This fixes most warnings when running npm ci, except one deprecated glob package.

@danleh danleh requested a review from rmahdav February 7, 2026 01:25
@danleh
Copy link
Collaborator Author

danleh commented Feb 7, 2026

Mhm, not sure why CI is failing, do we need to login somehow?

Run npm ci
  npm ci
  shell: /bin/bash -e {0}
npm error code E401
npm error Incorrect or missing password.
npm error If you were trying to login, change your password, create an
npm error authentication token or enable two-factor authentication then
npm error that means you likely typed your password in incorrectly.
npm error Please try again, or recover your password at:
npm error   https://www.npmjs.com/forgot
npm error
npm error If you were doing some other operation then your saved credentials are
npm error probably out of date. To correct this please try logging in again with:
npm error   npm login
npm error A complete log of this run can be found in: /Users/runner/.npm/_logs/2026-02-07T01_28_23_115Z-debug-0.log
Error: Process completed with exit code 1.

@rmahdav
Copy link
Collaborator

rmahdav commented Feb 9, 2026

I think the root cause of the problem is that for a lot (or maybe all) of the package updates, the public registry (https://registry.npmjs.org) has changed to internal google registry (https://us-npm.pkg.dev). We uses npm install in our build script which I believe get packages from the public registry.

I think we need to add a secret/token in setting and use it in CI yaml file to get an authenticated access to the registry with npm ci.

@brendandahl what is your opinion about this? Is this something else that we are missing?

@brendandahl
Copy link
Collaborator

We should probably use the regular npm registry, to keep this project buildable by other users. I'm guessing this came for the npm air gap thing in google?

@danleh
Copy link
Collaborator Author

danleh commented Feb 11, 2026

Right, my bad. Airlock had changed the registry. I re-ran npm install with npm config set registry https://registry.npmjs.org/ beforehand, let's see if that fixes it.

This fixes most warnings when running `npm ci`, except one deprecated glob package.
@danleh
Copy link
Collaborator Author

danleh commented Feb 11, 2026

@rmahdav Works now, could you take another look?

Copy link
Collaborator

@rmahdav rmahdav left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks Daniel!

@danleh danleh merged commit 0cef808 into GoogleChrome:main Feb 11, 2026
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants