Skip to content

Exclude experimental workloads#86

Merged
rmahdav merged 8 commits intomainfrom
exclude-experimental-workloads
Feb 10, 2026
Merged

Exclude experimental workloads#86
rmahdav merged 8 commits intomainfrom
exclude-experimental-workloads

Conversation

@rmahdav
Copy link
Collaborator

@rmahdav rmahdav commented Feb 6, 2026

In this PR:

  • We exclude the experimental workloads.
  • Update the CONTRIBUTING.md to have updated instructions.
  • Fix some typos in the CONTRIBUTING.md.

Fixes Issue #83

@rmahdav
Copy link
Collaborator Author

rmahdav commented Feb 6, 2026

Don't review it yet. I broke the CI.

@rmahdav rmahdav requested a review from brendandahl February 6, 2026 22:23
@rmahdav
Copy link
Collaborator Author

rmahdav commented Feb 6, 2026

Now that we exclude experimental workloads from the default set of tests, we are unable to run them as part of the CI test script (they are disabled), and it also makes sense to not include them in the end 2 end test script.

Copy link
Collaborator

@danleh danleh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@rmahdav
Copy link
Collaborator Author

rmahdav commented Feb 10, 2026

@danleh I add the check for not having 'default' and 'experimental' tag at the same time in this PR. Please take a look. Thanks!
@brendandahl can you also take a look at changes on run-end2end.mjs as well? Thanks!

@rmahdav rmahdav merged commit e878abc into main Feb 10, 2026
3 checks passed
@rmahdav rmahdav deleted the exclude-experimental-workloads branch February 10, 2026 18:13
@danleh
Copy link
Collaborator

danleh commented Feb 11, 2026

I add the check for not having 'default' and 'experimental' tag at the same time in this PR. Please take a look. Thanks!

Sorry for the late reply, but thanks for adding that! :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants