Skip to content

Better async and sync substep support #46

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
camillobruni wants to merge 8 commits into
base: main
Choose a base branch
from
Open

Better async and sync substep support #46

camillobruni wants to merge 8 commits into from

Conversation

@camillobruni
Copy link
Collaborator

@camillobruni camillobruni commented Dec 18, 2025

Fix issue #13

  • Make recording the Async substep configurable in AsyncBenchmarkStep
  • Use more consistent naming and only use step instead of test

@camillobruni camillobruni requested a review from rmahdav February 10, 2026 18:14
@camillobruni camillobruni requested a review from danleh February 10, 2026 18:31
@camillobruni
Copy link
Collaborator Author

camillobruni commented Feb 10, 2026

This should be ready now.

rmahdav
rmahdav reviewed Feb 10, 2026
View reviewed changes
Copy link
Collaborator

@rmahdav rmahdav left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LTGM % updating experimental/src/index.mjs as well to exclude async measurement. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@rmahdav rmahdav rmahdav left review comments

@danleh danleh Awaiting requested review from danleh

At least 1 approving review is required to merge this pull request.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@camillobruni @rmahdav