This repository has been archived by the owner on Mar 14, 2024. It is now read-only.
Add fallback size to hero so it doesn't shift. #2125
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Deploy preview for web-dev-staging ready! Built with commit 0092359 |
samthor
approved these changes
Feb 6, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I noticed most blog posts shift a lot as they load their hero image. I believe giving them
widthandheightfallback attributes is the approved way to define their intrinsic size (thread) and seems to help mitigate a lot of the shifting.Related css-tricks post.
Changes proposed in this pull request:
widthandheightfallback attributes to hero image to prevent layout shift.