Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix return type error #205

Merged
merged 3 commits into from
Nov 27, 2023
Merged

Fix return type error #205

merged 3 commits into from
Nov 27, 2023

Conversation

trymebytes
Copy link
Contributor

@trymebytes trymebytes commented Nov 22, 2023 •
edited
Loading

Fixes #204

@trymebytes trymebytes self-assigned this Nov 22, 2023
@trymebytes trymebytes marked this pull request as draft November 22, 2023 00:56
@trymebytes trymebytes marked this pull request as ready for review November 23, 2023 09:21
@trymebytes trymebytes requested review from amieiro and akirk November 23, 2023 09:21
akirk
akirk approved these changes Nov 23, 2023
View reviewed changes
Copy link
Member

@akirk akirk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, thanks!

akirk
akirk requested changes Nov 23, 2023
View reviewed changes
Copy link
Member

@akirk akirk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh, I think there is one projects check missing but I cannot highlight it. In line 526 of includes/class-wporg-notifications.php

@trymebytes
Copy link
Contributor Author

Oh, I think there is one projects check missing but I cannot highlight it. In line 526 of includes/class-wporg-notifications.php

I think since we already checked if the $original has a value then a project must exist. However, if a project doesn't exist then this line will return false.

@akirk
Copy link
Member

akirk commented Nov 23, 2023

Yes but in the if above we'll try to access a property on null.

@trymebytes trymebytes requested a review from akirk November 23, 2023 12:52
@trymebytes
Copy link
Contributor Author

Thank you!

@trymebytes trymebytes merged commit 1e78703 into main Nov 27, 2023
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@akirk akirk akirk approved these changes

@amieiro amieiro Awaiting requested review from amieiro

Assignees

@trymebytes trymebytes

Labels
None yet
Projects
None yet
Milestone
No milestone
2 participants
@trymebytes @akirk