Made RemoveUnnecessaryPackages consistent #696
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In the old code it would look for nuspec files on the file system and then remove folders that are not in packages.config. But installedPackages already contain all found nuspec files. The issue with old code is that InstalledPackages contained data about packages that were also potentially modified by the plugins while this method didn't take that into account leading to inconsistencies.
JoC0de
requested changes
Jan 31, 2025
popara96
approved these changes
Feb 1, 2025
JoC0de
approved these changes
Feb 1, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the old code it would look for nuspec files on the file system and then remove folders that are not in packages.config. But installedPackages already contain all found nuspec files. The issue with old code is that InstalledPackages contained data about packages that were also potentially modified by the plugins while this method didn't take that into account leading to inconsistencies.