Use Simulation.add_testbench for i2c tests. #733
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ahmedcharles
force-pushed
the
i2c_testbench
branch
from
df76ff5 to
4269972
Compare
whitequark
reviewed
Jan 30, 2025
whitequark
requested changes
Jan 30, 2025
There was a problem hiding this comment.
Thanks! Looks good other than the comment. (Please squash the commits once you fix that, and update the commit message to follow the format we use.)
ahmedcharles
force-pushed
the
i2c_testbench
branch
from
6fff458 to
ca5f494
Compare
ahmedcharles
force-pushed
the
i2c_testbench
branch
from
ca5f494 to
5a30b00
Compare
|
Is the format of the comment ok now? Thanks. |
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
|
Is the manual build issue due to my change? I don't think it is? |
|
No, it's just a flaky test... |
|
Thanks. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.