-
Notifications
You must be signed in to change notification settings - Fork 18
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feat/Cron job for sitemap generating on FE #1900
Conversation
WalkthroughA new cron job functionality has been implemented to generate sitemaps on the frontend. The changes involve adding a new service in the Changes
Sequence DiagramsequenceDiagram
participant Bootstrap as Server Bootstrap
participant CronJob as Sitemap Cron Job
participant Frontend as Frontend API
Bootstrap->>CronJob: Initialize runGenerateSitemapOnFrontend
CronJob->>Frontend: GET /api/generate-sitemap
Frontend-->>CronJob: Response
CronJob->>CronJob: Log job completion
Poem
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 1
🧹 Nitpick comments (1)
src/server/bootstrap.ts (1)
425-427
: Environment variable fallbackWhile this conditional check is helpful, consider verifying
process.env.FRONTEND_URL
as well, to prevent possible runtime failures if that variable is missing or invalid.
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (2)
src/server/bootstrap.ts
(2 hunks)src/services/cronJobs/generateSitemapOnFrontend.ts
(1 hunks)
🔇 Additional comments (2)
src/services/cronJobs/generateSitemapOnFrontend.ts (1)
1-9
: Good documentation and scheduling strategyIt's clear from the comment block that this cron job is designed to run every Sunday at 00:00 for generating a sitemap on the frontend. This documentation is helpful for future maintainers.
src/server/bootstrap.ts (1)
73-73
: Import is consistent with your new moduleImporting
runGenerateSitemapOnFrontend
here makes sense for integrating the feature.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approved!
Summary by CodeRabbit
New Features
Chores