Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix linkedin scope #1898

Merged
merged 1 commit into from
Dec 31, 2024
Merged

fix linkedin scope #1898

merged 1 commit into from
Dec 31, 2024

Conversation

lovelgeorge99
Copy link
Contributor

@lovelgeorge99 lovelgeorge99 commented Dec 30, 2024

Giveth/giveth-dapps-v2#4493 (comment)

https://community.auth0.com/t/the-linkedin-login-is-deprecated-updating-to-the-new-scopes-is-necessary/113696
The r_liteprofile is deprecated

Summary by CodeRabbit

  • Bug Fixes
    • Updated LinkedIn OAuth2 authentication scope to improve compatibility with the platform's authentication requirements.

Copy link
Contributor

coderabbitai bot commented Dec 30, 2024

Walkthrough

The pull request introduces a modification to the LinkedIn OAuth2 adapter, specifically updating the scope parameter in the authentication URL generation method. The change involves replacing the 'r_liteprofile' scope with 'profile', which may reflect updates to LinkedIn's API authentication requirements or access permissions.

Changes

File Change Summary
src/adapters/oauth2/linkedinAdapter.ts Updated LinkedIn OAuth2 scope from 'r_liteprofile' to 'profile' in getAuthUrl method

Poem

🐰 A LinkedIn Leap of Scope
With rabbit-like precision we hop
From 'r_liteprofile' to 'profile' we swap
An OAuth dance, a subtle tweak
Authentication's path we seek! 🔑

Tip

CodeRabbit's docstrings feature is now available as part of our Early Access Program! Simply use the command @coderabbitai generate docstrings to have CodeRabbit automatically generate docstrings for your pull request. We would love to hear your feedback on Discord.


📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between ff91c4d and b703497.

📒 Files selected for processing (1)
  • src/adapters/oauth2/linkedinAdapter.ts (1 hunks)
🔇 Additional comments (1)
src/adapters/oauth2/linkedinAdapter.ts (1)

22-22: Verify whether the 'profile' scope provides the necessary user details.

LinkedIn's documentation indicates that 'r_liteprofile' is deprecated, and 'profile' may be sufficient depending on your requirements. However, if your application relies on additional user field data (e.g., email), you might need to include other scopes (e.g., 'emailAddress'). Please confirm that this single 'profile' scope is adequate for retrieving the needed fields.

Use this script to search for references and confirm that no additional scope is needed:

✅ Verification successful

Let me gather more information about how the LinkedIn user data is being used.


Let me check the implementation of the LinkedIn adapter to see what user data is being retrieved.


The 'profile' scope is sufficient for the current implementation

Based on the code review, the LinkedIn adapter only requires basic profile information (ID, first name, and last name) which is covered by the 'profile' scope. The implementation:

  • Retrieves the access token
  • Makes a request to https://api.linkedin.com/v2/me
  • Only uses id, firstName.localized.en_US, and lastName.localized.en_US from the response

Since the application doesn't need email or other advanced profile information, the basic 'profile' scope is adequate for the current requirements.

🏁 Scripts executed

The following scripts were executed for the analysis:

Script:

#!/bin/bash
# This script helps verify references to LinkedIn scopes in the repository.
rg -A 3 'scope='

Length of output: 1409


Script:

#!/bin/bash
# Check how LinkedIn user data is processed
ast-grep --pattern 'getUserInfoByOauth2Code' -l ts
rg -A 10 'getUserInfoByOauth2Code.*linkedin' 

Length of output: 677


Script:

#!/bin/bash
# Check LinkedIn adapter implementation
cat src/adapters/oauth2/linkedinAdapter.ts

Length of output: 4078


Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR. (Beta)
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

Copy link
Collaborator

@kkatusic kkatusic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM ;) thx @lovelgeorge99

@lovelgeorge99 lovelgeorge99 merged commit b930c80 into staging Dec 31, 2024
5 checks passed
@lovelgeorge99 lovelgeorge99 deleted the fix-linkedin-scope branch December 31, 2024 13:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants