-
Notifications
You must be signed in to change notification settings - Fork 18
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix linkedin scope #1898
fix linkedin scope #1898
Conversation
WalkthroughThe pull request introduces a modification to the LinkedIn OAuth2 adapter, specifically updating the scope parameter in the authentication URL generation method. The change involves replacing the Changes
Poem
Tip CodeRabbit's docstrings feature is now available as part of our Early Access Program! Simply use the command 📜 Recent review detailsConfiguration used: CodeRabbit UI 📒 Files selected for processing (1)
🔇 Additional comments (1)src/adapters/oauth2/linkedinAdapter.ts (1)
LinkedIn's documentation indicates that Use this script to search for references and confirm that no additional scope is needed: ✅ Verification successfulLet me gather more information about how the LinkedIn user data is being used. Let me check the implementation of the LinkedIn adapter to see what user data is being retrieved. The Based on the code review, the LinkedIn adapter only requires basic profile information (ID, first name, and last name) which is covered by the
Since the application doesn't need email or other advanced profile information, the basic 🏁 Scripts executedThe following scripts were executed for the analysis: Script: #!/bin/bash
# This script helps verify references to LinkedIn scopes in the repository.
rg -A 3 'scope='
Length of output: 1409 Script: #!/bin/bash
# Check how LinkedIn user data is processed
ast-grep --pattern 'getUserInfoByOauth2Code' -l ts
rg -A 10 'getUserInfoByOauth2Code.*linkedin'
Length of output: 677 Script: #!/bin/bash
# Check LinkedIn adapter implementation
cat src/adapters/oauth2/linkedinAdapter.ts
Length of output: 4078 Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM ;) thx @lovelgeorge99
Giveth/giveth-dapps-v2#4493 (comment)
https://community.auth0.com/t/the-linkedin-login-is-deprecated-updating-to-the-new-scopes-is-necessary/113696
The
r_liteprofile
is deprecatedSummary by CodeRabbit