Skip to content

Commit

Permalink
FIX: changing model type so that the test doesn't file for landmark d…
Browse files Browse the repository at this point in the history
…etection
  • Loading branch information
bmalezieux committed Aug 14, 2024
1 parent 030eeec commit 95ebfea
Show file tree
Hide file tree
Showing 4 changed files with 4 additions and 4 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@
from .base import LandmarkDetectionBaseDetector


@maybe_detector("cropping_landmark", tags=["vision", "face", "landmark", "transformed", "cropped"])
@maybe_detector("cropping_landmark", tags=["vision", "face", "landmark_detection", "transformed", "cropped"])
class CroppingDetectorLandmark(LandmarkDetectionBaseDetector):
"""
Detector that evaluates models performance relative to a facial part
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -8,6 +8,6 @@
from .specs import DetectorSpecs


@maybe_detector("metadata_landmark", tags=["vision", "face", "landmark", "metadata"])
@maybe_detector("metadata_landmark", tags=["vision", "face", "landmark_detection", "metadata"])
class MetaDataScanDetectorLandmark(DetectorSpecs, MetaDataScanDetector):
surrogates = [SurrogateVolumeConvexHull, SurrogateNME]
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@
from .base import LandmarkDetectionBaseDetector


@maybe_detector("resize_landmark", tags=["vision", "face", "landmark", "transformed", "resized"])
@maybe_detector("resize_landmark", tags=["vision", "face", "landmark_detection", "transformed", "resized"])
class TransformationResizeDetectorLandmark(LandmarkDetectionBaseDetector):
"""
Detector that evaluates models performance on resized images
Expand Down
2 changes: 1 addition & 1 deletion giskard_vision/landmark_detection/models/base.py
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,7 @@
class FaceLandmarksModelBase(ModelBase):
"""Abstract class that serves as a template for all landmark model predictions"""

model_type = "landmark"
model_type = "landmark_detection"
prediction_result_cls = Types.prediction_result

def __init__(self, n_landmarks: int, n_dimensions: int, name: Optional[str] = None) -> None:
Expand Down

0 comments on commit 95ebfea

Please sign in to comment.