Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added giskard hub documentation #25

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

added giskard hub documentation #25

wants to merge 3 commits into from

Conversation

davidjanmercado
Copy link
Collaborator

No description provided.

@mattbit
Copy link
Member

mattbit commented Nov 22, 2024

Note:

  • fix TODOs
  • remove unnecessary files

Copy link
Member

@Hartorn Hartorn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remove also all .DS_Store and add the .DS_Store to git ignore ;)

@@ -0,0 +1,6 @@
{
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remove this file

@@ -0,0 +1,6 @@
{
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

To remove

@@ -0,0 +1 @@
{}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

To remove

Copy link
Member

@Hartorn Hartorn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I skimed through it, seems overall ok.

Glossary
=========

- **Models**: conversational agents configured through an API endpoint. They can be evaluated and tested within the Hub.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should probably be singular, same as for the rest ?


This section provides guidance on managing users in the Hub.

The Hub allows you to set access rights at two levels: global and scoped. To begin, click the "Account" icon in the upper right corner of the screen, then select "Settings." From the left panel, choose "User Management."
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actually, you can also limit to one specific entity.

As a side note, we probably need to give more details about what each right is doing

Generate a dataset
===================

This section guides you through generating a test dataset when you don’t have one at your disposal.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

don’t => don't (I think you are having special char here for quote)

:align: center
:alt: "List of conversations"

You can import data files in JSON or JSONL format, containing an array of conversations (or a conversation object per line, if JSONL).
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Soon to be updated to include CSV also


- The agent should mention its references.

- The agent should cite its references using the format [reference 1] for reference 1 and should not create a list, for example, [reference 1][reference 2][reference 3].
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe this one would be better as two rules no ? @mattbit

Copy link
Member

@Hartorn Hartorn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Global comment : image should be clickable & able to zoom in, it's too small atm
Also, the "Set access rights" section feels weird after the experiments in the playground.
I guess we may want to put subsection under quick start, and then the rest ?

Comment on lines +9 to +26
.. toctree::
:caption: Giskard Hub
:maxdepth: 1

hub/quickstart
hub/guide/manage-datasets
hub/guide/generate-dataset
hub/guide/run-evaluations
hub/guide/compare-evaluations
hub/guide/playground
hub/guide/access-rights
hub/guide/continuous-red-teaming
hub/glossary


----

The ``giskard_hub`` python library provides a simple way for developers and data
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's feeling a bit weird when you are on the page.
Was the idea to cut this into 2 ?

Create a project
=================

In this section, you will learn how to create a project. Before creating one, ensure you have properly configured the model (see Setup the model section). TODO LINK
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Handle TODO


.. note::

Models are conversational agents configured through an API endpoint. They can be evaluated and tested within the Hub.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

They can be evaluated feels wrong
Should we say They can be evaluated against datasets ? (and drop the tested part)

:align: center
:alt: "Generate correctness dataset"

However, dataset generation requires two additional pieces of information:
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

However, dataset generation => However, in this case, dataset generation


Clicking on a conversation will show a detailed comparison.

.. image:: /_static/images/hub/comparison-detail.png
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Image orientation is wrong


The Chat section is where you interrogate the agent. You write your message on the bottom part of the screen.

The left panel shows you the recent conversations. You can have as many conversations as you need. To add a new one, click the “New conversation” button. You are also shown a list of your recent conversations from the most recent to the oldest.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The left panel shows you the recent conversations => well, it shows all of them, most recent first, but that's ok

:align: center
:alt: "Set permissions"

Scoped permissions allow for more granular control. For each project, you can specify which pages or entities users are allowed to access.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Missing a concrete example of someone having read on everything in a project, and edit on a specific dataset


The playground is where you chat with your agent and check its response. The screen below shows the interface. The Chat section is where you interrogate the agent. You write your message on the bottom part of the screen. The left panel shows you the recent conversations. You can have as many conversations as you need. To add a new one, click the “New conversation” button. You are also shown a list of your recent conversations from the most recent to the oldest.

TODO IMAGE
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

To fix

Comment on lines +12 to +15
The Playground
===============

The playground is where you chat with your agent and check its response. The screen below shows the interface. The Chat section is where you interrogate the agent. You write your message on the bottom part of the screen. The left panel shows you the recent conversations. You can have as many conversations as you need. To add a new one, click the “New conversation” button. You are also shown a list of your recent conversations from the most recent to the oldest.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is duplicate from "Experiment from the playground"
Also, I accessed this page from the search, but not sure it's accessible another way ?


When the conversation is sufficient enough for what it needs to contain, you can send it to the dataset which you then use to evaluate your model.

TODO IMAGE
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fix me

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants