feat: Material に対する match を error にする Scalafix rule を追加 #2227
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
1_18ブランチはlinear historyであるべきなのかわからんから放置。多分squashでいいと思うんだけど… |
kory33
approved these changes
Sep 18, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
close #2226
org.bukkit.Meterialをマッチ式で検査している場合エラーにする scalafix rules を追加#2226 にある通り、これを書くだけでコンパイル時間が増大するため、気づかないことがないように。
補足情報:
scalafix --rules="file:src/scalafix/scala/fix/MatchForMaterialToErrorForPerformance.scala"で実行できる。