Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migration kotlinOptions to compilerOptions #289

Merged

Conversation

taeheeL
Copy link
Contributor

@taeheeL taeheeL commented Nov 4, 2024

🎯 Goal

According to the official Kotlin documentation, kotlinOptions has been deprecated, and it is recommended to migrate to compilerOptions. Therefore, the goal of this task is to migrate the deprecated kotlinOptions in the Gradle build scripts to the new compilerOptions.

🛠 Implementation details

Removed the usage of the extension function related to kotlinOptions, namely kotlinOptions(block: KotlinJvmOptions.() -> Unit).

fun CommonExtension<*, *, *, *, *, *>.kotlinOptions(block: KotlinJvmOptions.() -> Unit) {
  (this as ExtensionAware).extensions.configure("kotlinOptions", block)
}

Applied compilerOptions to all Kotlin compile tasks by utilizing tasks.withType<KotlinCompile>(). This approach ensures that the updated compiler configurations are consistently applied across all modules and source sets in the project.

tasks.withType<KotlinCompile>().configureEach {
    compilerOptions {
        // Compiler options configuration
    }
}

@taeheeL taeheeL requested a review from skydoves as a code owner November 4, 2024 19:34
Copy link
Member

@skydoves skydoves left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me :) Thank you for your contribution!

@skydoves skydoves enabled auto-merge November 5, 2024 00:30
@skydoves skydoves merged commit 269b084 into GetStream:main Nov 5, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants