Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[PBE-0] support livestream #584

Draft
wants to merge 2 commits into
base: develop
Choose a base branch
from
Draft

[PBE-0] support livestream #584

wants to merge 2 commits into from

Conversation

kanat
Copy link
Contributor

@kanat kanat commented Oct 23, 2024

🎯 Goal

Add Live tab to the Detailed DetailedCallingView, to start (or join) the "livestream" call type.

🎨 Showcase

Before After
BEFORE AFTER

🧪 Manual Testing Notes

Explain how this change can be tested manually, if applicable.

☑️ Contributor Checklist

  • I have signed the Stream CLA (required)
  • This change follows zero ⚠️ policy (required)
  • This change should receive manual QA
  • Changelog is updated with client-facing changes
  • New code is covered by unit tests
  • Comparison screenshots added for visual changes
  • Affected documentation updated (Docusaurus, tutorial, CMS)

🎁 Meme

Provide a funny gif or image that relates to your work on this pull request. (Optional)

@kanat kanat requested a review from a team as a code owner October 23, 2024 16:15
@Stream-SDK-Bot
Copy link
Collaborator

SDK Size

title develop branch diff status
StreamVideo 7.41 MB 7.41 MB 0 KB 🟢
StreamVideoSwiftUI 2.18 MB 2.18 MB 0 KB 🟢
StreamVideoUIKit 2.31 MB 2.31 MB 0 KB 🟢
StreamWebRTC 8.69 MB 8.69 MB 0 KB 🟢

@github-actions GitHub Actions
Copy link

1 Error
🚫 Please start subject with capital letter.
f2e1a63
1 Warning
⚠️ Please be sure to complete the Contributor Checklist in the Pull Request description

Generated by 🚫 Danger

@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Oct 23, 2024

Quality Gate Passed Quality Gate passed

Issues
113 New issues
0 Accepted issues

Measures
0 Security Hotspots
78.2% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

@kanat kanat marked this pull request as draft October 23, 2024 16:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@kanat @Stream-SDK-Bot