Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[PBE-6219] Make number of participants more accurate in call session (lobby) #1220

Open
wants to merge 2 commits into
base: develop
Choose a base branch
from
Open

[PBE-6219] Make number of participants more accurate in call session (lobby) #1220

wants to merge 2 commits into from
+183 −23

Conversation

liviu-timar
Copy link
Member

@liviu-timar liviu-timar commented Oct 31, 2024 •
edited
Loading

🎯 Goal

We need to handle the new call.session_participant_count_updated event & overall improve the participant count logic.

🛠 Implementation details

  • Handling new CallSessionParticipantCountsUpdatedEvent event
  • Improved existing participant events to update the byRole map in the call session
  • Updating call.state.participantCounts from new event in lobby state and from SFU Health Check after join.

@liviu-timar liviu-timar requested a review from a team as a code owner October 31, 2024 15:33
skydoves
skydoves approved these changes Nov 1, 2024
View reviewed changes
Copy link
Member

@skydoves skydoves left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks very good to me!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@skydoves skydoves skydoves approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@liviu-timar @skydoves