Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not watch channels when searching by channels #3472

Merged

Conversation

nuno-vieira
Copy link
Member

@nuno-vieira nuno-vieira commented Oct 24, 2024

🔗 Issue Links

None

🎯 Goal

Fixes watching channels when performing channel search.

🧪 Manual Testing Notes

N/A

☑️ Contributor Checklist

  • I have signed the Stream CLA (required)
  • This change should be manually QAed
  • Changelog is updated with client-facing changes
  • Changelog is updated with new localization keys
  • New code is covered by unit tests
  • Comparison screenshots added for visual changes
  • Affected documentation updated (docusaurus, tutorial, CMS)

@nuno-vieira nuno-vieira added the 🐞 Bug An issue or PR related to a bug label Oct 24, 2024
@nuno-vieira nuno-vieira requested a review from a team as a code owner October 24, 2024 18:07
@Stream-SDK-Bot
Copy link
Collaborator

SDK Size

title develop branch diff status
StreamChat 6.92 MB 6.92 MB 0 KB 🟢
StreamChatUI 4.95 MB 4.95 MB 0 KB 🟢

@Stream-SDK-Bot
Copy link
Collaborator

SDK Performance

target metric benchmark branch performance status
MessageList Hitches total duration 10 ms 11.68 ms -16.8% 🔽 🔴
Duration 2.6 s 2.54 s 2.31% 🔼 🟢
Hitch time ratio 4 ms per s 4.6 ms per s -15.0% 🔽 🔴
Frame rate 75 fps 77.68 fps 3.57% 🔼 🟢
Number of hitches 1 1.0 0.0% 🟰 🟢

@Stream-SDK-Bot
Copy link
Collaborator

SDK Size

title develop branch diff status
StreamChat 6.92 MB 6.92 MB 0 KB 🟢
StreamChatUI 4.95 MB 4.95 MB 0 KB 🟢

Copy link

sonarcloud bot commented Oct 24, 2024

Copy link
Contributor

@martinmitrevski martinmitrevski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good one 👍

@nuno-vieira nuno-vieira merged commit 55fe259 into develop Oct 24, 2024
15 checks passed
@nuno-vieira nuno-vieira deleted the fix/do-not-watch-channels-when-searching-channels branch October 24, 2024 22:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🐞 Bug An issue or PR related to a bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants