Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[CI] Print sdk size in PRs #3329

Merged
merged 5 commits into from
Jul 24, 2024
Merged

[CI] Print sdk size in PRs #3329

merged 5 commits into from
Jul 24, 2024

Conversation

testableapple
Copy link
Contributor

🔗 Issue Links

Resolve https://stream-io.atlassian.net/browse/PBE-4314

🎯 Goal

Show the SDK size for each PR

☑️ Contributor Checklist

  • I have signed the Stream CLA (required)
  • This change should be manually QAed
  • Changelog is updated with client-facing changes
  • Changelog is updated with new localization keys
  • New code is covered by unit tests
  • Comparison screenshots added for visual changes
  • Affected documentation updated (docusaurus, tutorial, CMS)

🎁 Meme

gif

@testableapple testableapple added the 🤖 CI/CD Any work related to CI/CD label Jul 23, 2024
@testableapple testableapple requested a review from a team as a code owner July 23, 2024 16:18
@testableapple testableapple marked this pull request as draft July 23, 2024 16:24
@testableapple testableapple marked this pull request as ready for review July 23, 2024 16:24
@github-actions GitHub Actions
Copy link

github-actions bot commented Jul 23, 2024 •
edited
Loading

4 Errors
🚫 Please use more than one word.
8618cc4
🚫 Please use more than one word.
9deb4ae
🚫 Please use more than one word.
7062827
🚫 Please use more than one word.
1cc5f39

Generated by 🚫 Danger

@testableapple testableapple marked this pull request as draft July 23, 2024 16:29
@testableapple testableapple added the 🔧 WIP A PR that is Work in Progress label Jul 23, 2024
@testableapple testableapple marked this pull request as ready for review July 23, 2024 16:29
@Stream-SDK-Bot
Copy link
Collaborator

SDK Size

StreamChat StreamChatUI Total
6.7MB 4.4MB 11.1MB

@testableapple testableapple removed the 🔧 WIP A PR that is Work in Progress label Jul 23, 2024
martinmitrevski
martinmitrevski approved these changes Jul 24, 2024
View reviewed changes
Copy link
Contributor

@martinmitrevski martinmitrevski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM ✅ We also need this for video 🙏

@testableapple testableapple merged commit 5773202 into develop Jul 24, 2024
12 of 13 checks passed
@testableapple testableapple deleted the ci/sdk-size-pr branch July 24, 2024 09:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@martinmitrevski martinmitrevski martinmitrevski approved these changes

Assignees
No one assigned
Labels
🤖 CI/CD Any work related to CI/CD
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@testableapple @Stream-SDK-Bot @martinmitrevski