Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for enabling message list view animations #3314

Merged
merged 4 commits into from
Jul 18, 2024

Conversation

nuno-vieira
Copy link
Member

@nuno-vieira nuno-vieira commented Jul 18, 2024

🔗 Issue Links

Resolves https://stream-io.atlassian.net/browse/PBE-5174

🎯 Goal

Add support for enabling message list animations as requested by some customers.

🧪 Manual Testing Notes

  1. Login
  2. Open a Channel
  3. Send a message
  4. Load more messages
  5. No animations should be present
  6. Logout
  7. Go to configration screen
  8. Enable animations
  9. Repeat 2, 3, 4
  10. Should have animations

☑️ Contributor Checklist

  • I have signed the Stream CLA (required)
  • This change should be manually QAed
  • Changelog is updated with client-facing changes
  • Changelog is updated with new localization keys
  • New code is covered by unit tests
  • Comparison screenshots added for visual changes
  • Affected documentation updated (docusaurus, tutorial, CMS)

@nuno-vieira nuno-vieira added the ✅ Feature An issue or PR related to a feature label Jul 18, 2024
@nuno-vieira nuno-vieira requested a review from a team as a code owner July 18, 2024 01:05
@Stream-SDK-Bot
Copy link
Collaborator

StreamChat XCMetrics

target metric benchmark branch performance status
MessageList Hitches total duration 10 ms 5.01 ms 49.9% 🔼 🟢
Duration 2.6 s 2.55 s 1.92% 🔼 🟢
Hitch time ratio 4 ms per s 1.97 ms per s 50.75% 🔼 🟢
Frame rate 75 fps 78.29 fps 4.39% 🔼 🟢
Number of hitches 1 0.4 60.0% 🔼 🟢
ChannelList Hitches total duration 12.5 ms 9.18 ms 26.56% 🔼 🟢
Duration 2.6 s 2.54 s 2.31% 🔼 🟢
Hitch time ratio 5 ms per s 3.61 ms per s 27.8% 🔼 🟢
Frame rate 72 fps 74.17 fps 3.01% 🔼 🟢
Number of hitches 1.2 1.0 16.67% 🔼 🟢

@laevandus
Copy link
Contributor

Tried it with animations enabled but seems like it is not very smooth because the timestamp appears for a split second. Should we fix that separately?
https://github.com/user-attachments/assets/9727115e-419b-4205-bf3e-9191ced5d893

Copy link
Contributor

@martinmitrevski martinmitrevski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we put some disclaimer that if you enable this mode, you're in control of the animations (and the possible glitches)?

@nuno-vieira
Copy link
Member Author

Tried it with animations enabled but seems like it is not very smooth because the timestamp appears for a split second. Should we fix that separately? https://github.com/user-attachments/assets/9727115e-419b-4205-bf3e-9191ced5d893

Yes, this is one of the cons of having this enabled. The customer is fine with this, so at least we give this flexibility to customers in case they want to customize it. And maybe for their UI is not that bad. The biggest problem is really loading previous messages, sometimes the messages float around.

@nuno-vieira nuno-vieira merged commit 459dfe0 into develop Jul 18, 2024
1 check passed
@nuno-vieira nuno-vieira deleted the add/allow-enabling-message-list-animations branch July 18, 2024 10:25
Copy link

sonarcloud bot commented Jul 18, 2024

@Stream-SDK-Bot Stream-SDK-Bot mentioned this pull request Jul 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
✅ Feature An issue or PR related to a feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants