Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

4.50.0 Release #3073

Merged
merged 16 commits into from
Mar 12, 2024
Merged

4.50.0 Release #3073

merged 16 commits into from
Mar 12, 2024

Conversation

testableapple
Copy link
Contributor

StreamChat

✅ Added

  • Add new ChatMessage.textUpdatedAt for when the message text is edited #3059
  • Expose ClientError.errorPayload to easily check for server error details #3061

🐞 Fixed

  • Fix token provider retrying after calling disconnect #3052
  • Fix connect user never completing when disconnecting after token provider fails #3052
  • Fix current user cache not deleted on logout causing unread count issues after switching users #3055
  • Fix rare crash in startObserver() on logout when converting DTO to model in itemCreator #3053
  • Fix invalid token triggering token refresh in an infinite loop #3056
  • Do not mark a message as failed when the server returns duplicated message error #3061

StreamChatUI

✅ Added

  • Add new Components.isMessageEditedLabelEnabled #3059
  • Add "Edited" label when a message is edited #3059
    • Note: For now, only when the text changes it is marked as edited.
  • Add message.edited localization key #3059

nuno-vieira and others added 16 commits February 28, 2024 11:49
@nuno-vieira
Call missing super.init in AsyncOperation (#3046)
0f13c43
@dependabot
Bump rack from 3.0.9 to 3.0.9.1 (#3050)
3d7c371
@nuno-vieira
Fix token provider retrying after calling disconnect (#3052)
128a891 
* Change the ChatClient to singleton in the DemoApp

This is usually how customers integrate our SDK. Besides this, it is also useful to investigate connection and retry issues.

* Add a way to fake token refresh failure in the Demo App

* Fix token refresh still retrying after disconnect or logout

* Reset the number of refreshes when logging in the user again

* Fix connecting user never finishes after disconnecting when refresh token fails

* Update CHANGELOG.md

* Fix test test_clearTokenProvider_thenIsGettingTokenFalse

* Allow disconnecting user only in the Demo App
@testableapple
Implement performance benchmarks (#2978)
5c1b5fd
@testableapple
[CI] Soft check for excess files on PR creation (#3054)
c1d3dd0
@nuno-vieira
Fix current user cache not deleted on logout causing unread count iss…
35c366d 
…ues after switching users (#3055)

* Fix current user cache not delete on logout causing unread count issues after switching users

* Update CHANGELOG.md
@nuno-vieira
Fix invalid token triggering token refresh in an infinite loop (#3056)
44527c8 
* Fix invalid token calling token refresh in an infinite loop

* Update CHANGELOG.md

* Update CHANGELOG.md
@nuno-vieira
Stop throwing InvalidModel when dto is invalid (#3053)
f2df616 
* Stop throwing InvalidModel when dto is invalid

* Update CHANGELOG.md
@testableapple
Check XCMetrics on CI (#3060)
d158f16
@nuno-vieira
Add support for "Edited" label when message text is edited (#3059)
8eef5a6 
* Expose `textUpdatedAt` in `ChatMessage`

* When message is edited, optimistically update the `textUpdatedAt` property

* Add UI to show "Edited At" label when message text is edited

* Add LLC Tests

* Add UI Test coverage

* Update CHANGELOG.md

* Update CHANGELOG.md

* Update Components.swift

* Fix "Edited At" label typo

* Revert optimistic updates for textUpdatedAt

* Fix edited label showing for deleted messages
@nuno-vieira
Update CHANGELOG.md (#3062)
4d89ae7
@nuno-vieira
Do not mark message as failed when server returns duplicated message …
f8690e3 
…error (#3061)

* Expose `errorPayload` from server in `ClientError`

* Do not mark a message as failed when server returns duplicated message error

* Update CHANGELOG.md

* Make sure that the error is only when a duplicated message is sent

* Update CHANGELOG.md
@testableapple
Add a static benchmark for xcmetrics (#3063)
267fefb
@jeroenleenarts
Remove agora and 100ms (#3067)
90cc9b7
@testableapple
Fix E2E test on iPad (#3070)
57d73c3
@testableapple
Bump 4.50.0
234c959
@testableapple testableapple requested a review from a team as a code owner March 11, 2024 16:22
@github-actions GitHub Actions
Copy link

1 Warning
⚠️ Big PR

Generated by 🚫 Danger

@github-actions GitHub Actions
Copy link

Build for regression testing №123456991 has been uploaded to TestFlight 🎁

@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Mar 11, 2024

Quality Gate Passed Quality Gate passed

Issues
47 New issues
0 Accepted issues

Measures
0 Security Hotspots
91.6% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

@GetStream GetStream deleted a comment from Stream-SDK-Bot Mar 11, 2024
@Stream-SDK-Bot
Copy link
Collaborator

StreamChat XCMetrics

target metric benchmark branch performance status
MessageList Hitches total duration 10 ms 5.01 ms 49.9% 🔼 🟢
Duration 2.6 s 2.55 s 1.92% 🔼 🟢
Hitch time ratio 4 ms per s 1.97 ms per s 50.75% 🔼 🟢
Frame rate 79 fps 78.64 fps 0.46% 🔼 🟢
Number of hitches 1 0.6 40.0% 🔼 🟢
ChannelList Hitches total duration 12.5 ms 9.18 ms 26.56% 🔼 🟢
Duration 2.6 s 2.54 s 2.31% 🔼 🟢
Hitch time ratio 5 ms per s 3.61 ms per s 27.8% 🔼 🟢
Frame rate 76 fps 74.49 fps 1.99% 🔼 🟢
Number of hitches 1.2 1.0 16.67% 🔼 🟢

@GetStream GetStream deleted a comment from Stream-SDK-Bot Mar 12, 2024
@testableapple testableapple merged commit 234c959 into main Mar 12, 2024
17 checks passed
@testableapple testableapple deleted the release/4.50.0 branch March 12, 2024 11:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@testableapple @Stream-SDK-Bot @nuno-vieira @jeroenleenarts