Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(deps): drop remark-gfm version #2471

Merged
merged 3 commits into from
Aug 15, 2024

Conversation

arnautov-anton
Copy link
Contributor

Submit a pull request

🎯 Goal

When user posts a specific message, the whole application crashes due to this issue.

This PR lowers remark-gfm to a version that works well with the current version of the react-markdown used within the SDK.

I won't be posting the breaking message in the PR for the obvious reasons, message me if interested.

Copy link

codecov bot commented Aug 15, 2024

Codecov Report

Attention: Patch coverage is 73.33333% with 4 lines in your changes missing coverage. Please review.

Project coverage is 85.46%. Comparing base (28e26ca) to head (ff3b9a4).
Report is 16 commits behind head on release-v11.

Files Patch % Lines
src/components/UtilityComponents/ErrorBoundary.tsx 69.23% 4 Missing ⚠️
Additional details and impacted files
@@               Coverage Diff               @@
##           release-v11    #2471      +/-   ##
===============================================
- Coverage        85.48%   85.46%   -0.03%     
===============================================
  Files              393      395       +2     
  Lines             9122     9142      +20     
  Branches          2356     2359       +3     
===============================================
+ Hits              7798     7813      +15     
- Misses            1122     1127       +5     
  Partials           202      202              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@arnautov-anton arnautov-anton merged commit 1b359f7 into release-v11 Aug 15, 2024
8 checks passed
@arnautov-anton arnautov-anton deleted the fix/drop-remark-gfm-version branch August 15, 2024 14:10
github-actions bot pushed a commit that referenced this pull request Aug 15, 2024
## [12.0.0-rc.8](v12.0.0-rc.7...v12.0.0-rc.8) (2024-08-15)

### Bug Fixes

* **deps:** drop remark-gfm version ([#2471](#2471)) ([1b359f7](1b359f7))
* do not rerender on client options update ([#2465](#2465)) ([81f33ba](81f33ba))
* do not rerender on client options update ([#2465](#2465)) ([3899352](3899352))
* downgrade react-markdown to v8 that supports React version < v18 ([#2461](#2461)) ([5e6fea0](5e6fea0))
* forward StreamChat constructor options via useCreateChatClient ([#2463](#2463)) ([310835d](310835d))
* prevent ChannelPreviews with duplicate keys ([1a075ad](1a075ad))
* prevent including own user in read count displayed in MessageStatus ([#2459](#2459)) ([061d1a3](061d1a3))
* provide both browser and node cjs bundles ([#2457](#2457)) ([273ea2a](273ea2a))

### Chores

* **deps:** remove unused isomorphic-ws from dependencies ([853bd8b](853bd8b))
@stream-ci-bot
Copy link
Collaborator

🎉 This PR is included in version 12.0.0-rc.8 🎉

The release is available on:

Your semantic-release bot 📦🚀

github-actions bot pushed a commit that referenced this pull request Aug 15, 2024
## [11.23.6](v11.23.5...v11.23.6) (2024-08-15)

### Bug Fixes

* **deps:** drop remark-gfm version ([#2471](#2471)) ([1b359f7](1b359f7))
@stream-ci-bot
Copy link
Collaborator

🎉 This PR is included in version 11.23.6 🎉

The release is available on:

Your semantic-release bot 📦🚀

@minhth1529
Copy link

Hi @arnautov-anton after upgrade to this version I got an issues

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants