Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

perf(package-size): remove react-file-utils package #2088

Merged
merged 4 commits into from
Sep 8, 2023

Conversation

arnautov-anton
Copy link
Contributor

🎯 Goal

Move components from react-file-utils and remove the package from the SDK.

@codecov-commenter
Copy link

codecov-commenter commented Sep 7, 2023

Codecov Report

Patch coverage: 70.82% and project coverage change: -0.58% ⚠️

Comparison is base (a319aa6) 82.21% compared to head (9a5ebc0) 81.63%.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #2088      +/-   ##
===========================================
- Coverage    82.21%   81.63%   -0.58%     
===========================================
  Files          263      287      +24     
  Lines         6438     6759     +321     
  Branches      1816     1927     +111     
===========================================
+ Hits          5293     5518     +225     
- Misses         834      912      +78     
- Partials       311      329      +18     
Files Changed Coverage Δ
...rc/components/MessageInput/hooks/useAttachments.ts 96.55% <ø> (ø)
...ponents/MessageInput/hooks/useMessageInputState.ts 78.30% <ø> (ø)
src/components/MessageInput/hooks/utils.ts 58.22% <ø> (ø)
...nts/ReactFileUtilities/FileIcon/FileIconSet/v2.tsx 29.78% <29.78%> (ø)
...omponents/ReactFileUtilities/ImageUploadButton.tsx 40.00% <40.00%> (ø)
...nts/ReactFileUtilities/FileIcon/FileIconSet/v1.tsx 46.15% <46.15%> (ø)
src/components/ReactFileUtilities/utils.ts 48.97% <48.97%> (ø)
...onents/ReactFileUtilities/ThumbnailPlaceholder.tsx 50.00% <50.00%> (ø)
src/components/ReactFileUtilities/Thumbnail.tsx 60.00% <60.00%> (ø)
...components/ReactFileUtilities/LoadingIndicator.tsx 75.00% <75.00%> (ø)
... and 25 more

☔ View full report in Codecov by Sentry.

📢 Have feedback on the report? Share it here.

@arnautov-anton arnautov-anton changed the title perf(deps): remove react-file-utils package perf(package-size): remove react-file-utils package Sep 8, 2023
oliverlaz
oliverlaz previously approved these changes Sep 8, 2023
MartinCupela
MartinCupela previously approved these changes Sep 8, 2023
@arnautov-anton arnautov-anton merged commit 1258e09 into develop Sep 8, 2023
3 of 4 checks passed
@arnautov-anton arnautov-anton deleted the perf/remove-react-file-utils branch September 8, 2023 13:57
@MartinCupela MartinCupela mentioned this pull request Sep 8, 2023
github-actions bot pushed a commit that referenced this pull request Sep 8, 2023
# [10.10.0](v10.9.1...v10.10.0) (2023-09-08)

### Features

* add link previews to MessageInput ([#2083](#2083)) ([76caeea](76caeea))

### Performance Improvements

* **package-size:** remove react-file-utils package ([#2088](#2088)) ([1258e09](1258e09))
@github-actions
Copy link

github-actions bot commented Sep 8, 2023

🎉 This PR is included in version 10.10.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants