WIP: feat: add new Carousel component #1667
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
# Conflicts: # src/components/Message/MessageSimple.tsx # src/components/Message/__tests__/MessageText.test.js
oliverlaz
approved these changes
Jul 21, 2022
arnautov-anton
force-pushed
the
master
branch
from
2cc3b70
to
a510e8f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🎯 Goal
Provide own stream-chat-react carousel that would meet the following:
position: relativeelementsDepends on:
GetStream/stream-chat-css#147
Todo:
[ ] Tests
....
🛠 Implementation details
Drag-scrolling logic is separated (
useDragScrolling) from the basic carousel navigation (useCarouselController). The drag-scrolling logic can be disabled and navigation can be performed with arrow buttons on the sides of the carousel aperture.🎨 UI Changes
Desktop
carousel_desktop.webm
Mobile
carousel_mobile.webm