refactor(app): add SetEnforceUniqueUsernames to restrict allowed values #257
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: jnelle <[email protected]> * Since I couldn't find the allowed values in the GO SDK docs, I decided to add this, because it restricts the allowed values and shows the developer which values are allowed
Signed-off-by: jnelle <[email protected]>
dudemelo
reviewed
Mar 21, 2024
| default: | ||
| result = "app" | ||
| } | ||
| return &result |
There was a problem hiding this comment.
Does this need to be a pointer? Because I believe that Go's "escape analysis" will put this in the heap instead of stack.
This beauty thing Go does to avoid dangling pointer—since variable should only exists inside the function—always bug my brain. 🤯
There was a problem hiding this comment.
You're right, it doesn't have to be. Gonna change it later
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CLA
Description of the pull request
Since I couldn't find the allowed values in the GO SDK docs, I decided to add the SetEnforceUniqueUsernames function, because it restricts the allowed values and shows the developer which values are allowed.